ci(e2e): use INTEGRATION_STAGING_INSTANCE_KEYS for mobile-e2e workflow#8498
ci(e2e): use INTEGRATION_STAGING_INSTANCE_KEYS for mobile-e2e workflow#8498wobsoriano merged 2 commits intomainfrom
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThis PR updates the mobile e2e GitHub Actions workflow to derive Clerk instance credentials from the Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/mobile-e2e.yml:
- Line 82: The sk extraction step lacks the same fail-fast guard as the pk
extraction, so update the sk assignment (the line setting sk=$(echo
"$INTEGRATION_STAGING_INSTANCE_KEYS" | jq -er ".[\"$EXPO_INSTANCE_NAME\"].sk"))
to mirror the pk pattern by adding the same || { echo "::error::..."; exit 1 }
fallback so the job fails with a clear message when .sk is missing or null;
apply this identical change to the ios job's sk extraction as well and ensure
subsequent steps that call actions/github-script add-mask or output the sk will
not receive an empty value.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: 9fab495e-b3cf-4175-b960-3f5853c27536
📒 Files selected for processing (1)
.github/workflows/mobile-e2e.yml
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/dev-cli
@clerk/expo
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/hono
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
Summary
INTEGRATION_INSTANCE_KEYStoINTEGRATION_STAGING_INSTANCE_KEYS.clerkstage-with-native-componentsinstance lives in the staging secret (same onee2e-staging.ymluses), not the production one.Without this, the manual run fails fast with
No entry 'clerkstage-with-native-components' found in INTEGRATION_INSTANCE_KEYS.Test plan
Mobile e2e (@clerk/expo)from the Actions tab onmainand confirm the "Resolve Clerk instance keys" step passes.