Skip to content

ci(e2e): use INTEGRATION_STAGING_INSTANCE_KEYS for mobile-e2e workflow#8498

Merged
wobsoriano merged 2 commits intomainfrom
chris/mobile-e2e-staging-secret
May 7, 2026
Merged

ci(e2e): use INTEGRATION_STAGING_INSTANCE_KEYS for mobile-e2e workflow#8498
wobsoriano merged 2 commits intomainfrom
chris/mobile-e2e-staging-secret

Conversation

@chriscanin
Copy link
Copy Markdown
Member

Summary

  • Switches the mobile-e2e workflow's "Resolve Clerk instance keys" step from reading INTEGRATION_INSTANCE_KEYS to INTEGRATION_STAGING_INSTANCE_KEYS.
  • The clerkstage-with-native-components instance lives in the staging secret (same one e2e-staging.yml uses), not the production one.
  • Updates header comment to match.

Without this, the manual run fails fast with No entry 'clerkstage-with-native-components' found in INTEGRATION_INSTANCE_KEYS.

Test plan

  • After merge, trigger Mobile e2e (@clerk/expo) from the Actions tab on main and confirm the "Resolve Clerk instance keys" step passes.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 7, 2026

⚠️ No Changeset found

Latest commit: 52a3d24

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link
Copy Markdown

vercel Bot commented May 7, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
clerk-js-sandbox Ready Ready Preview, Comment May 7, 2026 6:40pm

Request Review

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 7, 2026

Review Change Stack
No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 9599e0de-e412-4b35-bdf7-f183407c9c1f

📥 Commits

Reviewing files that changed from the base of the PR and between 605ee4e and 52a3d24.

📒 Files selected for processing (2)
  • .github/workflows/mobile-e2e.yml
  • scripts/resolve-instance-keys.mjs
🚧 Files skipped from review as they are similar to previous changes (1)
  • .github/workflows/mobile-e2e.yml

📝 Walkthrough

Walkthrough

This PR updates the mobile e2e GitHub Actions workflow to derive Clerk instance credentials from the INTEGRATION_STAGING_INSTANCE_KEYS secret instead of INTEGRATION_INSTANCE_KEYS. The workflow adds documentation comments describing the new secret as a JSON map indexed by EXPO_INSTANCE_NAME. Both the Android and iOS job's "Resolve Clerk instance keys" steps are updated to validate the new secret is set, parse the instance name from the environment, and extract .pk and .sk values from the JSON map with early failure if the named entry is missing. The output used for BAPI provisioning (CLERK_SECRET_KEY) is sourced from step output as before.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

  • clerk/javascript#8495: Modifies the same mobile-e2e workflow's Clerk instance resolution logic by changing which environment value is used for instance selection alongside this PR's secret migration.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: switching the mobile-e2e workflow to use INTEGRATION_STAGING_INSTANCE_KEYS instead of INTEGRATION_INSTANCE_KEYS.
Description check ✅ Passed The description clearly explains the motivation, the specific change, and includes relevant context about why the staging secret is needed for the clerkstage-with-native-components instance.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/mobile-e2e.yml:
- Line 82: The sk extraction step lacks the same fail-fast guard as the pk
extraction, so update the sk assignment (the line setting sk=$(echo
"$INTEGRATION_STAGING_INSTANCE_KEYS" | jq -er ".[\"$EXPO_INSTANCE_NAME\"].sk"))
to mirror the pk pattern by adding the same || { echo "::error::..."; exit 1 }
fallback so the job fails with a clear message when .sk is missing or null;
apply this identical change to the ios job's sk extraction as well and ensure
subsequent steps that call actions/github-script add-mask or output the sk will
not receive an empty value.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 9fab495e-b3cf-4175-b960-3f5853c27536

📥 Commits

Reviewing files that changed from the base of the PR and between 4c44aa6 and 605ee4e.

📒 Files selected for processing (1)
  • .github/workflows/mobile-e2e.yml

Comment thread .github/workflows/mobile-e2e.yml Outdated
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 7, 2026

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8498

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8498

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8498

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8498

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8498

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8498

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8498

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8498

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8498

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8498

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8498

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8498

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8498

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8498

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8498

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8498

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8498

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8498

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8498

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8498

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8498

commit: 52a3d24

@wobsoriano wobsoriano merged commit 888a68c into main May 7, 2026
43 checks passed
@wobsoriano wobsoriano deleted the chris/mobile-e2e-staging-secret branch May 7, 2026 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants