Skip to content

⚡️ Speed up method ListExp.getValueType by 6% #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
codeflash-ai wants to merge 1 commit into
base: master
Choose a base branch
from
Open

⚡️ Speed up method ListExp.getValueType by 6% #22

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 8 additions & 22 deletions client/src/com/aerospike/client/exp/ListExp.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -482,28 +482,14 @@ private static Exp addRead(Exp bin, byte[] bytes, Exp.Type retType) {
private static Exp.Type getValueType(int returnType) {
int t = returnType & ~ListReturnType.INVERTED;

switch (t) {
case ListReturnType.INDEX:
case ListReturnType.REVERSE_INDEX:
case ListReturnType.RANK:
case ListReturnType.REVERSE_RANK:
// This method only called from expressions that can return multiple integers (ie list).
return Exp.Type.LIST;

case ListReturnType.COUNT:
return Exp.Type.INT;

case ListReturnType.VALUE:
// This method only called from expressions that can return multiple objects (ie list).
return Exp.Type.LIST;

case ListReturnType.EXISTS:
return Exp.Type.BOOL;

default:
case ListReturnType.NONE:
throw new AerospikeException("Invalid ListReturnType: " + returnType);
}
return switch (t) {
case ListReturnType.INDEX, ListReturnType.REVERSE_INDEX,
ListReturnType.RANK, ListReturnType.REVERSE_RANK,
ListReturnType.VALUE -> Exp.Type.LIST;
case ListReturnType.COUNT -> Exp.Type.INT;
case ListReturnType.EXISTS -> Exp.Type.BOOL;
default -> throw new AerospikeException("Invalid ListReturnType: " + returnType);
};
}

protected static byte[] packRangeOperation(int command, int returnType, Exp begin, Exp end, CTX[] ctx) {
Expand Down