Skip to content

⚡️ Speed up method StringValue.equals by 28% #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
codeflash-ai wants to merge 1 commit into
base: master
Choose a base branch
from
Open

⚡️ Speed up method StringValue.equals by 28% #31

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions client/src/com/aerospike/client/Value.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -753,9 +753,21 @@ public String toString() {

@Override
public boolean equals(Object other) {
return (other != null &&
this.getClass().equals(other.getClass()) &&
this.value.equals(((StringValue)other).value));
// Fast path: same reference
if (this == other) {
return true;
}
// Null check
if (other == null) {
return false;
}
// Ensure exact same runtime class (preserve original semantics)
if (this.getClass() != other.getClass()) {
return false;
}
// Safe cast and value comparison
StringValue o = (StringValue) other;
return this.value.equals(o.value);
}

@Override
Expand Down