Skip to content

⚡️ Speed up method JavaImportResolver._is_external_library by 148% in PR #1199 (omni-java) #1372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
codeflash-ai wants to merge 1 commit into
base: omni-java
Choose a base branch
from
Open

⚡️ Speed up method JavaImportResolver._is_external_library by 148% in PR #1199 (omni-java) #1372

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 25 additions & 2 deletions codeflash/languages/java/import_resolver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,11 @@ def __init__(self, project_root: Path) -> None:
self._source_roots: list[Path] = []
self._test_roots: list[Path] = []
self._package_to_path_cache: dict[str, Path | None] = {}
self._external_library_cache: dict[str, bool] = {}
try:
self._common_prefix_set: frozenset[str] = frozenset(self.COMMON_EXTERNAL_PREFIXES)
except AttributeError:
self._common_prefix_set = frozenset()

# Discover source and test roots
self._discover_roots()
Expand Down Expand Up @@ -150,9 +155,27 @@ def _is_standard_library(self, import_path: str) -> bool:

def _is_external_library(self, import_path: str) -> bool:
"""Check if an import is from a known external library."""
for prefix in self.COMMON_EXTERNAL_PREFIXES:
if import_path.startswith(prefix + ".") or import_path == prefix:
result = self._external_library_cache.get(import_path)
if result is not None:
return result

if import_path in self._common_prefix_set:
self._external_library_cache[import_path] = True
return True

parts = import_path.split(".")
prefix = parts[0]
if prefix in self._common_prefix_set:
self._external_library_cache[import_path] = True
return True

for part in parts[1:]:
prefix = prefix + "." + part
if prefix in self._common_prefix_set:
self._external_library_cache[import_path] = True
return True

self._external_library_cache[import_path] = False
return False

def _resolve_to_file(self, import_path: str) -> Path | None:
Expand Down
Loading