Skip to content

⚡️ Speed up function _consume_ent by 57% #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
codeflash-ai wants to merge 1 commit into
base: master
Choose a base branch
from
Open

⚡️ Speed up function _consume_ent by 57% #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 23 additions & 11 deletions spacy/training/iob_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,20 +36,32 @@ def _consume_ent(tags: List[str]) -> List[str]:
tag = tags.pop(0)
target_in = "I" + tag[1:]
target_last = "L" + tag[1:]
length = 1
while tags and tags[0] in {target_in, target_last}:
length += 1
tags.pop(0)
label = tag[2:]
if length == 1:
if len(label) == 0:
raise ValueError(Errors.E177.format(tag=tag))
return ["U-" + label]
else:
if not label:
raise ValueError(Errors.E177.format(tag=tag))

# Linear scan index-based (no per-item pop, pop once)
n = len(tags)
length = 1
for i in range(n):
t = tags[i]
if t == target_in or t == target_last:
length += 1
else:
break
if length > 1:
# Remove the matched tags in one shot, once the final length found
del tags[: length - 1]
start = "B-" + label
end = "L-" + label
middle = [f"I-{label}" for _ in range(1, length - 1)]
return [start] + middle + [end]
# List multiplication is faster than list comprehension for repeated strings
if length > 2:
middle = ["I-" + label] * (length - 2)
return [start] + middle + [end]
else:
return [start, end]
else:
return ["U-" + label]


def doc_to_biluo_tags(doc: Doc, missing: str = "O"):
Expand Down