Skip to content

⚡️ Speed up function like_num by 275% #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
codeflash-ai wants to merge 1 commit into
base: master
Choose a base branch
from
Open

⚡️ Speed up function like_num by 275% #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions spacy/lang/ko/lex_attrs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,10 +52,19 @@ def like_num(text):
if text.isdigit():
return True
if text.count("/") == 1:
num, denom = text.split("/")
num, denom = text.split("/", 1)
if num.isdigit() and denom.isdigit():
return True
if any(char.lower() in _num_words for char in text):
# Optimize word membership test by using a set for O(1) lookups
# This avoids rebuilding the set every invocation and avoids .lower() which is a no-op for Korean.
# Building the set once and storing in a default argument is safe and fast.
_num_word_set = getattr(like_num, "_num_word_set", None)
if _num_word_set is None:
from spacy.lang.ko.lex_attrs import _num_words

_num_word_set = set(_num_words)
like_num._num_word_set = _num_word_set
if any(char in _num_word_set for char in text):
return True
return False

Expand Down