Repository navigation
Conversation
|
| checkRecursive(expr, startEndTokens.first, startEndTokens.second->next(), exprVarIds, local, true, depth); | ||
| if (result.type != Result::Type::NONE) | ||
| return result; | ||
| { |
There was a problem hiding this comment.
this is quite pedantic by clang imho. FwdAnalysis::Result is small and simple data. But yes if we want to turn on the warning then you have to fix all warnings so I guess there's not much we can do.
| return "0.0"; | ||
| if (s.find_first_of(".e") == std::string::npos) | ||
| return s + ".0"; | ||
| s = "0.0"; |
There was a problem hiding this comment.
hmm I like the old code better here from a readability point of view.
| result = execute(elseStart->scope()); | ||
| } else { | ||
| return {unknown()}; | ||
| result = {unknown()}; |
There was a problem hiding this comment.
it is less obvious what happens here. if the loop continues then other results can be returned.. so I want to see an unconditional return.
| overflow = true; | ||
| indexValues.push_back(values.front()); | ||
| } | ||
| if (overflow) |
There was a problem hiding this comment.
this looks more weird imho.
|
This pull request has merge conflicts that must be resolved. |
3 participants
No description provided.