Repository navigation
fix(plugin-basic-ui): respect Modal and BottomSheet safe areas - #770
Draft
ENvironmentSet wants to merge 1 commit into
Draft
ENvironmentSet wants to merge 1 commit into
ENvironmentSet wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: 14ec96f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying stackflow-demo with
|
| Latest commit: |
14ec96f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7cb0f7f1.stackflow-demo.pages.dev |
| Branch Preview URL: | https://feature-fep-3133.stackflow-demo.pages.dev |
commit: |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
stackflow-docs | 14ec96f | Commit Preview URL | Oct 23 2026, 11:04 AM |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modal and BottomSheet content can overlap device safe areas. This change follows the confirmed FEP-3133 specification.
2.5remmargins andmaxWidthwith a full-screen backdrop.constant(...)thenenv(..., 0px)fallback order, add border-box sizing, and document duplicate-inset handling in Korean and English. Include a plugin-basic-ui patch changeset.Validation was performed by a separate agent after independent code review; the review's documentation finding was resolved.
yarn workspace @stackflow/plugin-basic-ui typecheckpassed.git diff --cached --checkpassed.yarn changeset status --since=origin/mainpassed and detected the plugin-basic-ui patch. Existing docs/history-sync version warnings remain.Nonzero inset cases replaced only the generated CSS safe-area expressions with test variables. Physical iOS/Android devices and legacy iOS
constant()rendering were not tested.