Skip to content

fix(plugin-basic-ui): respect Modal and BottomSheet safe areas - #770

Draft
ENvironmentSet wants to merge 1 commit into
mainfrom
feature/fep-3133
Draft

ENvironmentSet wants to merge 1 commit into
mainfrom
feature/fep-3133

Conversation

@ENvironmentSet

Copy link
Copy Markdown
Collaborator

Modal and BottomSheet content can overlap device safe areas. This change follows the confirmed FEP-3133 specification.

  • Center Modal inside all four safe area insets, preserving its horizontal 2.5rem margins and maxWidth with a full-screen backdrop.
  • Add left, right, and bottom padding to BottomSheet content while its background stays full-width and bottom-aligned.
  • Preserve the constant(...) then env(..., 0px) fallback order, add border-box sizing, and document duplicate-inset handling in Korean and English. Include a plugin-basic-ui patch changeset.

Validation was performed by a separate agent after independent code review; the review's documentation finding was resolved.

  • Dependency-ordered builds for core, config, React, react-ui-core, plugin-basic-ui, and plugin-renderer-basic passed.
  • yarn workspace @stackflow/plugin-basic-ui typecheck passed.
  • Biome checks for both changed CSS files and git diff --cached --check passed.
  • yarn changeset status --since=origin/main passed and detected the plugin-basic-ui patch. Existing docs/history-sync version warnings remain.
  • Actual Stackflow components passed 116 Chromium assertions across 390×844 and 844×390 viewports: zero, single-sided, asymmetric, and dynamic insets; geometry and maxWidth; child padding; background coverage; overflow; inside/outside clicks and preventDefault; opening/closing transitions. No browser runtime errors were observed.

Nonzero inset cases replaced only the generated CSS safe-area expressions with test variables. Physical iOS/Android devices and legacy iOS constant() rendering were not tested.

@changeset-bot

changeset-bot Bot commented Oct 23, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 14ec96f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@stackflow/plugin-basic-ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai

coderabbitai Bot commented Oct 23, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying stackflow-demo with  Cloudflare Pages  Cloudflare Pages

Latest commit: 14ec96f
Status: ✅  Deploy successful!
Preview URL: https://7cb0f7f1.stackflow-demo.pages.dev
Branch Preview URL: https://feature-fep-3133.stackflow-demo.pages.dev

View logs

@pkg-pr-new

pkg-pr-new Bot commented Oct 23, 2026

Copy link
Copy Markdown
  • @stackflow/demo

    yarn add https://pkg.pr.new/@stackflow/plugin-basic-ui@770.tgz
    

commit: 14ec96f

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
stackflow-docs 14ec96f Commit Preview URL Oct 23 2026, 11:04 AM

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant