Skip to content

Commit 1b7a8e1

Browse files
committed
Fix a few derps
Change-Id: Iaa04459581d40b39b4776993fd7e78ace9f6f47f
1 parent a57f794 commit 1b7a8e1

5 files changed

Lines changed: 27 additions & 15 deletions

File tree

core/java/android/provider/Settings.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3833,12 +3833,13 @@ public boolean validate(String value) {
38333833
* Network traffic switch
38343834
* @hide
38353835
*/
3836-
public static final String NETWORK_TRAFFIC_OLD = "network_traffic_old";
3836+
public static final String NETWORK_TRAFFIC_OLD_STATE = "network_traffic_old_state";
38373837

38383838
/**
38393839
* Network traffic indicator, goes from least to greatest significant bitwise
3840-
* 0 = Display down-stream traffic if set
3841-
* 1 = Show as Byte/s if set
3840+
* 0 = Display up-stream traffic if set
3841+
* 1 = Display down-stream traffic if set
3842+
* 2 = Show as Byte/s if set
38423843
* 16-31 = Refresh interval(ms) min: 250 max: 32750 default: 1000
38433844
* @hide
38443845
*/

packages/SystemUI/res/values/pa_dimens.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@
4949
<dimen name="pie_battery_width">3.5sp</dimen>
5050
<dimen name="pie_shader_width">1dp</dimen>
5151
<dimen name="pie_settings_offset">55dp</dimen>
52-
<dimen name="pie_settings_offset_land">210dp</dimen>
52+
<dimen name="pie_settings_offset_land">240dp</dimen>
5353
<dimen name="pie_status_item_size">16dp</dimen>
5454
<dimen name="pie_status_offset">20dp</dimen>
5555
<dimen name="pie_status_text_top_margin">13dp</dimen>

packages/SystemUI/src/com/android/systemui/statusbar/BaseStatusBar.java

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -764,6 +764,9 @@ public void start() {
764764
mContext.getContentResolver().registerContentObserver(
765765
Settings.Secure.getUriFor(Settings.Secure.PIE_GRAVITY), false,
766766
mSettingsObserver, UserHandle.USER_ALL);
767+
mContext.getContentResolver().registerContentObserver(
768+
Settings.Secure.getUriFor(Settings.Secure.PIE_LEFT_HANDED), false,
769+
mSettingsObserver, UserHandle.USER_ALL);
767770
if (ENABLE_LOCK_SCREEN_ALLOW_REMOTE_INPUT) {
768771
mContext.getContentResolver().registerContentObserver(
769772
Settings.Secure.getUriFor(Settings.Secure.LOCK_SCREEN_ALLOW_REMOTE_INPUT),
@@ -882,6 +885,10 @@ public void start() {
882885
}
883886

884887
public void updatePieControls(boolean enabled) {
888+
updatePieControls(enabled, false);
889+
}
890+
891+
public void updatePieControls(boolean enabled, boolean override) {
885892
ContentResolver resolver = mContext.getContentResolver();
886893

887894
if (enabled) {
@@ -898,7 +905,7 @@ public void updatePieControls(boolean enabled) {
898905

899906
int gravity = Settings.Secure.getIntForUser(resolver,
900907
Settings.Secure.PIE_GRAVITY, 0, UserHandle.USER_CURRENT);
901-
mPieController.resetPie(enabled, gravity);
908+
mPieController.resetPie(enabled, gravity, override);
902909
}
903910

904911
public void toggleOrientationListener(boolean enable) {
@@ -936,7 +943,7 @@ private void getOrientationListener() {
936943
public void onOrientationChanged(int orientation) {
937944
int rotation = mDisplay.getRotation();
938945
if (rotation != mOrientation) {
939-
if (mPieController != null) mPieController.detachPie();
946+
if (mPieController != null) mPieController.updatePie();
940947
mOrientation = rotation;
941948
}
942949
}
@@ -1077,7 +1084,7 @@ protected void onConfigurationChanged(Configuration newConfig) {
10771084
}
10781085
int rotation = mDisplay.getRotation();
10791086
if (rotation != mOrientation) {
1080-
if (mPieController != null) mPieController.detachPie();
1087+
if (mPieController != null) mPieController.updatePie();
10811088
mOrientation = rotation;
10821089
}
10831090
}

packages/SystemUI/src/com/android/systemui/statusbar/pie/PieController.java

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -130,10 +130,14 @@ public void detachPie() {
130130
}
131131

132132
public void attachPie() {
133-
mBar.updatePieControls(true);
133+
mBar.updatePieControls(true, true);
134134
}
135135

136-
public void resetPie(boolean enabled, int gravity) {
136+
public void updatePie() {
137+
mBar.updatePieControls(mPieAttached);
138+
}
139+
140+
public void resetPie(boolean enabled, int gravity, boolean override) {
137141
mRotation = mWindowManager.getDefaultDisplay().getRotation();
138142

139143
if (mPieAttached) {
@@ -143,17 +147,17 @@ public void resetPie(boolean enabled, int gravity) {
143147
}
144148
mPieAttached = false;
145149
}
146-
if (enabled) attachPie(gravity);
150+
if (enabled) attachPie(gravity, override);
147151
}
148152

149153
private boolean showPie() {
150-
final boolean pieEnabled = Settings.Secure.getIntForUser(mContext.getContentResolver(),
154+
boolean pieEnabled = Settings.Secure.getIntForUser(mContext.getContentResolver(),
151155
Settings.Secure.PIE_STATE, 0, UserHandle.USER_CURRENT) == 1;
152156
return pieEnabled;
153157
}
154158

155-
public void attachPie(int gravity) {
156-
if(showPie()) {
159+
public void attachPie(int gravity, boolean override) {
160+
if(showPie() && (!mKeyguardManager.inKeyguardRestrictedInputMode() || override)) {
157161
// want some slice?
158162
switch (gravity) {
159163
// this is just main gravity, the trigger is centered later
@@ -387,7 +391,7 @@ && activateFromListener(touchX, touchY)) {
387391
@Override
388392
public void run() {
389393
if (!gainTouchFocus(mPie.getWindowToken())) {
390-
detachPie();
394+
updatePie();
391395
}
392396
restoreListenerState();
393397
}

packages/SystemUI/src/com/android/systemui/statusbar/pie/PieMenu.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -453,7 +453,7 @@ private void getDimensions() {
453453
}
454454
setColor(mNOTLogo, mDarkThemeEnabled ? mForegroundColor : mBackgroundColor);
455455
mTogglePoint[mNumberOfSnapPoints++] = new NowOnTapPoint(mWidth / 2 +
456-
(mPanelOrientation == Gravity.BOTTOM ? 0 : (isLandScape() ? (pieRight ? mWidth / 7 : -mWidth / 7)
456+
(mPanelOrientation == Gravity.BOTTOM ? 0 : (isLandScape() ? (pieRight ? mWidth / 6 : -mWidth / 6)
457457
: (pieRight ? -mNOTOffsetX : mNOTOffsetX))), mHeight / 2 +
458458
(mPanelOrientation == Gravity.BOTTOM ? mNOTOffsetY : 0),
459459
mNOTRadius, mNOTLogo, mNOTSize);

0 commit comments

Comments
 (0)