Skip to content

Commit 021fc6c

Browse files
docs(bots): reconcile design-doc SHA prose with the actual pin (3963f4b)
Addresses the engineer-bot's "needs human decision" review thread: the code pin is correct (3963f4b = latest engine main, single-sourced in bot-prelude), but the design doc's chronological prose still surfaced superseded SHAs (d780b2d, d24ca21, b6205fb, d9cb1e6) as if current. Add an AUTHORITATIVE banner at the top stating the current pin + wiring (banner wins over the draft history below), and mark the stale "Pinned to d9cb1e6" line as as-written history. No code change — .github/ already pins only 3963f4b. Signed-off-by: Eric Wang <e.wang@databricks.com> Co-authored-by: Isaac Signed-off-by: eric-wang-1990 <e.wang@databricks.com>
1 parent 91efcd5 commit 021fc6c

1 file changed

Lines changed: 19 additions & 4 deletions

File tree

docs/superpowers/specs/2026-07-14-onboard-bot-engine-design.md

Lines changed: 19 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,19 @@
44
**Status:** Approved (pending spec review)
55
**Repo:** `databricks/databricks-sql-python`
66

7+
> **AUTHORITATIVE — current state (read this, not the chronology below).**
8+
> - **Engine pin:** `3963f4be76be3b4ac0382ca0d7b6bf9d051929e6` (latest
9+
> `databricks-bot-engine` main), defined in **ONE** place —
10+
> `.github/actions/bot-prelude` `engine-ref` default. `.github/` has no other
11+
> SHA.
12+
> - **Wiring:** each bot is its **own job** calling the local `bot-prelude`
13+
> `install-bot-engine` composites (the engine is pip-installed, PAT-free via an
14+
> engine-scoped App token). We do **not** `uses:` the engine's reusable
15+
> workflows — that doesn't resolve cross-repo.
16+
> - The `## Engine pin` / `## Design` sections and the `d780b2d…`, `d24ca21`,
17+
> `b6205fb`, `d9cb1e6` SHAs below are the **superseded draft history**, kept
18+
> for context. Where they conflict with this banner, the banner wins.
19+
720
## Problem
821

922
The repo currently runs the PR **reviewer bot** from *vendored* code under
@@ -195,10 +208,12 @@ databricks-bot-engine, adopting **both** bots and used to surface onboarding
195208
friction back to the engine.
196209

197210
### Reviewer — flipped to PAT-free App-auth
198-
Pinned to engine SHA `d9cb1e63dc31eed550194a29d1cfd7de9c9c793b` (post-#107, which
199-
selects the engineer author flow from the issue **Type** — Bug ⇒ bug-fix,
200-
Task/Feature ⇒ task (the engine renamed the old `enhancement` flow to `task`);
201-
earlier drafts pinned `d24ca217`, then `b6205fb`, post-#100). Both reviewer
211+
Pinned to engine SHA `d9cb1e63dc31eed550194a29d1cfd7de9c9c793b` at the time of
212+
this update (the pin has since advanced to `3963f4b` — see the banner at the top;
213+
this paragraph is left as-written history). The pin selects the engineer author
214+
flow from the issue **Type** — Bug ⇒ bug-fix, Task/Feature ⇒ task (the engine
215+
renamed the old `enhancement` flow to `task`); earlier drafts pinned `d24ca217`,
216+
then `b6205fb`, post-#100. Both reviewer
202217
workflows pass `engine-auth: app` and **drop `engine-pat`**: the reusable mints a
203218
short-lived, engine-scoped GitHub App installation token from the review-bot App
204219
creds it already receives. No `BOT_ENGINE_PAT` secret. The same SHA is pinned in

0 commit comments

Comments
 (0)