replaceOne not upserting?

[skedwards88]

From this Slack conversation

When I execute the following code, I would expect upsertion. However, it looks like no documents are replaced or upserted.

        Filter filter = Filters.eq("_id", "Idontexist");
        Document newDocument = new Document()
            .append("isCheckedOut", false)
            .append("borrower", "Brook Reed");
        ReplaceOneOptions options = new ReplaceOneOptions().upsert(true);
        UpdateResult result = collection.replaceOne(filter, newDocument, options);
        System.out.println(result.getMatchedCount());
        System.out.println(result.getModifiedCount());
        System.out.println(result.getUpsertedId());

prints

0
0
null

[clun]

The exact request associated with the expression above is:

{

  "findOneAndReplace": {
    "filter": {
      "_id": "Idontexist"
    },
    "replacement": {
      "isCheckedOut": false,
      "borrower": "Brook Reed"
    },
    "options": {
      "upsert": true,
      "returnDocument": "before"
    }
  }
}

that is returning:

{
  "data": {
    "document": null
  },
  "status": {
    "matchedCount": 0,
    "modifiedCount": 0,
    "upsertedId": "Idontexist"
  }
}

• The item is inserted in the collection

• But the property result.getUpsertedId() should be populated.

• Ok we are in the case of the returned document is null and an upsertid is provided, the code was missing the corner case, code is updated.