Skip to content

Commit 4ea44d6

Browse files
committed
refactor(data-inspector): ph icons via unocss instead of inline svg
DataSourceSelect used inline <svg> for the trigger caret and the item check indicator (copied from FormSelect). Replace both with i-ph:caret-down and i-ph:check spans rendered through the shared presetIcons mask, matching the design-system convention of icons everywhere.
1 parent 0147cc5 commit 4ea44d6

1 file changed

Lines changed: 2 additions & 6 deletions

File tree

plugins/data-inspector/src/spa/components/DataSourceSelect.vue

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -30,9 +30,7 @@ function iconOf(source: DataSourceMeta | undefined): string {
3030
<span class="truncate font-semibold text-primary">{{ active?.title ?? placeholder ?? 'Data source' }}</span>
3131
</span>
3232
<SelectIcon class="op-fade shrink-0">
33-
<svg width="1em" height="1em" viewBox="0 0 24 24" aria-hidden="true">
34-
<path fill="none" stroke="currentColor" stroke-width="2" stroke-linecap="round" d="m6 9l6 6l6-6" />
35-
</svg>
33+
<span class="i-ph:caret-down" aria-hidden="true" />
3634
</SelectIcon>
3735
</SelectTrigger>
3836
<SelectPortal>
@@ -57,9 +55,7 @@ function iconOf(source: DataSourceMeta | undefined): string {
5755
<span v-if="source.description" class="text-11px color-faint truncate">{{ source.description }}</span>
5856
</span>
5957
<SelectItemIndicator class="color-active inline-flex items-center shrink-0 mt-0.5">
60-
<svg width="0.85em" height="0.85em" viewBox="0 0 24 24" aria-hidden="true">
61-
<path fill="none" stroke="currentColor" stroke-width="3" stroke-linecap="round" stroke-linejoin="round" d="M20 6L9 17l-5-5" />
62-
</svg>
58+
<span class="i-ph:check" aria-hidden="true" />
6359
</SelectItemIndicator>
6460
</SelectItem>
6561
</SelectViewport>

0 commit comments

Comments
 (0)