-
-
Notifications
You must be signed in to change notification settings - Fork 66
Description
Bug Report
What's the issue you encountered?
The Makefile of graphics/bitmap/24bit-color tries to use old ImageMagick commands, which result in it not working.
In particular, in line 203, it uses @convert when the command in new ImageMagick versions was replaced to magick since convert is a command installed by default on Windows
Additionally, it searches for ImageMagick in System32 in line 134, but ImageMagick isn't installed by default in System32 (at least it didn't install it there in my machine), promting the user to install it, even when they already have it installed.
The Readme also incorrectly tells the user to use convert
How can the issue be reproduced?
To Reproduce.
Install 3ds-dev tooling
Download/clone the examples from this repo
Download the most recent version of ImageMagick
Uses MSYS2 to navigate to the graphics/bitmap/24bit-color folder
Run make
One of 2 error messages will be displayed
(if the search path for ImageMagick is in System32, it will prompt the user to install it again)
(else, an error related to the Windows convert filesystem command will be displayed)
Fix
Replace @convert for @magick in line 203 and maybe fix whatever is going on in line 134
Modify the Readme to replace convert for magick
Environment?
Windows, using MSYS2
Official Release