remove unnecessary field and helper

Author: ilopezluna

cmd/cli/desktop/desktop.go

@@ -105,7 +105,7 @@ func (c *Client) Status() Status {
 	}
 }
 
-func (c *Client) Pull(model string, ignoreRuntimeMemoryCheck bool, printer standalone.StatusPrinter) (string, bool, error) {
+func (c *Client) Pull(model string, printer standalone.StatusPrinter) (string, bool, error) {
 	model = normalizeHuggingFaceModelName(model)
 
 	// Check if this is a Hugging Face model and if HF_TOKEN is set
@@ -116,9 +116,8 @@ func (c *Client) Pull(model string, ignoreRuntimeMemoryCheck bool, printer stand
 
 	return c.withRetries("download", 3, printer, func(attempt int) (string, bool, error, bool) {
 		jsonData, err := json.Marshal(dmrm.ModelCreateRequest{
-			From:                     model,
-			IgnoreRuntimeMemoryCheck: ignoreRuntimeMemoryCheck,
-			BearerToken:              hfToken,
+			From:        model,
+			BearerToken: hfToken,
 		})
 		if err != nil {
 			// Marshaling errors are not retryable

pkg/inference/models/api.go

@@ -14,9 +14,6 @@ import (
 type ModelCreateRequest struct {
 	// From is the name of the model to pull.
 	From string `json:"from"`
-	// IgnoreRuntimeMemoryCheck indicates whether the server should check if it has sufficient
-	// memory to run the given model (assuming default configuration).
-	IgnoreRuntimeMemoryCheck bool `json:"ignore-runtime-memory-check,omitempty"`
 	// BearerToken is an optional bearer token for authentication.
 	BearerToken string `json:"bearer-token,omitempty"`
 }

pkg/inference/scheduling/loader.go

@@ -194,15 +194,6 @@ func (l *loader) broadcast() {
 	}
 }
 
-// formatMemorySize formats a memory size in bytes as a string.
-// Values of 0 or 1 are treated as sentinel values for "unknown" memory size.
-func formatMemorySize(bytes uint64) string {
-	if bytes <= 1 {
-		return "unknown"
-	}
-	return fmt.Sprintf("%d MB", bytes/1024/1024)
-}
-
 // freeRunnerSlot frees a runner slot.
 // The caller must hold the loader lock.
 func (l *loader) freeRunnerSlot(slot int, key runnerKey) {

pkg/inference/scheduling/loader_test.go

@@ -125,65 +125,6 @@ func createAliveTerminableMockRunner(log *logrus.Entry, backend inference.Backen
 	}
 }
 
-// TestFormatMemorySize tests the formatMemorySize helper function
-func TestFormatMemorySize(t *testing.T) {
-	tests := []struct {
-		name     string
-		bytes    uint64
-		expected string
-	}{
-		{
-			name:     "sentinel value 0 is unknown",
-			bytes:    0,
-			expected: "unknown",
-		},
-		{
-			name:     "sentinel value 1 is unknown",
-			bytes:    1,
-			expected: "unknown",
-		},
-		{
-			name:     "2 bytes is still unknown (edge case)",
-			bytes:    2,
-			expected: "0 MB",
-		},
-		{
-			name:     "1 MB",
-			bytes:    1024 * 1024,
-			expected: "1 MB",
-		},
-		{
-			name:     "512 MB",
-			bytes:    512 * 1024 * 1024,
-			expected: "512 MB",
-		},
-		{
-			name:     "1 GB",
-			bytes:    1024 * 1024 * 1024,
-			expected: "1024 MB",
-		},
-		{
-			name:     "8 GB",
-			bytes:    8 * 1024 * 1024 * 1024,
-			expected: "8192 MB",
-		},
-		{
-			name:     "fractional MB rounds down",
-			bytes:    1024*1024 + 512*1024, // 1.5 MB
-			expected: "1 MB",
-		},
-	}
-
-	for _, tt := range tests {
-		t.Run(tt.name, func(t *testing.T) {
-			result := formatMemorySize(tt.bytes)
-			if result != tt.expected {
-				t.Errorf("formatMemorySize(%d) = %q, want %q", tt.bytes, result, tt.expected)
-			}
-		})
-	}
-}
-
 // TestMakeRunnerKey tests that runner keys are created correctly
 func TestMakeRunnerKey(t *testing.T) {
 	tests := []struct {