LanguageFeature.WarningWhenCopyAndUpdateRecordChangesAllFields has shipped since F# 8.0 and is enabled for every selectable language version (the minimum accepted --langversion is 8.0). Its feature flag can therefore never be turned off, so it is dead configuration. This issue removes the flag and collapses the guarded code to its enabled behaviour.
What to remove
- The
WarningWhenCopyAndUpdateRecordChangesAllFields case in LanguageFeatures.fs and LanguageFeatures.fsi
- Its entry in the
features map and its GetFeatureString arm
- The
featureWarningWhenCopyAndUpdateRecordChangesAllFields string in FSComp.txt
- Every
SupportsFeature LanguageFeature.WarningWhenCopyAndUpdateRecordChangesAllFields / checkLanguageFeatureAndRecover … WarningWhenCopyAndUpdateRecordChangesAllFields guard — keep only the enabled path and delete the legacy branch
- Adjust affected tests and baselines accordingly
Consequence: --disableLanguageFeature:WarningWhenCopyAndUpdateRecordChangesAllFields is no longer a recognised feature name.
Version mapping
|
LanguageFeature.WarningWhenCopyAndUpdateRecordChangesAllFields, languageVersion80 |
Feature string
|
featureWarningWhenCopyAndUpdateRecordChangesAllFields,"Raises warnings when an copy-and-update record expression changes all fields of a record." |
Part of #20139
LanguageFeature.WarningWhenCopyAndUpdateRecordChangesAllFieldshas shipped since F# 8.0 and is enabled for every selectable language version (the minimum accepted--langversionis 8.0). Its feature flag can therefore never be turned off, so it is dead configuration. This issue removes the flag and collapses the guarded code to its enabled behaviour.What to remove
WarningWhenCopyAndUpdateRecordChangesAllFieldscase inLanguageFeatures.fsandLanguageFeatures.fsifeaturesmap and itsGetFeatureStringarmfeatureWarningWhenCopyAndUpdateRecordChangesAllFieldsstring inFSComp.txtSupportsFeature LanguageFeature.WarningWhenCopyAndUpdateRecordChangesAllFields/checkLanguageFeatureAndRecover … WarningWhenCopyAndUpdateRecordChangesAllFieldsguard — keep only the enabled path and delete the legacy branchConsequence:
--disableLanguageFeature:WarningWhenCopyAndUpdateRecordChangesAllFieldsis no longer a recognised feature name.Version mapping
fsharp/src/Compiler/Facilities/LanguageFeatures.fs
Line 208 in ea778bb
Feature string
fsharp/src/Compiler/FSComp.txt
Line 1601 in ea778bb
Part of #20139