Skip to content

Commit 106cd3b

Browse files
committed
pr feedback
1 parent 84b778d commit 106cd3b

File tree

3 files changed

+4
-16
lines changed

3 files changed

+4
-16
lines changed

example/nextjs/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,8 @@ This sticks to the native Next.js file boundaries instead of inventing another f
3131

3232
- The server helper flushes the Exceptionless queue explicitly. That matters for short-lived serverless runtimes where a background timer may not get enough time to send queued events.
3333
- The route handler uses `after()` so normal server logs flush after the response is sent.
34-
- The example locally aliases `source-map` to `false` in `next.config.mjs` so an unused `stacktrace-gps` AMD branch does not leak a `source-map` dependency into `@exceptionless/browser`.
35-
- The helper files import the built ESM bundles from `packages/browser/dist/index.bundle.js` and `packages/node/dist/index.bundle.js` because the package entrypoints still re-export internal `#/*` imports. The example also uses `--webpack` because Turbopack currently rejects the node bundle during page data collection on `node-localstorage`'s dynamic `require`.
34+
- The example imports `@exceptionless/browser` and `@exceptionless/node` directly and uses the default Next.js bundler behavior, which is Turbopack on Next 16.
35+
- Because this is a workspace example, you still need the root `npm run build` step before starting it locally so the SDK packages have fresh `dist/` output.
3636
- If we later package this for production ergonomics, the clean split is likely a very thin `@exceptionless/nextjs` helper for framework hooks plus an optional `@exceptionless/vercel` add-on for `@vercel/otel`, deployment metadata, and queue-flush helpers.
3737

3838
### Environment variables

example/nextjs/next.config.mjs

Lines changed: 0 additions & 12 deletions
This file was deleted.

example/nextjs/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@
33
"private": true,
44
"version": "3.0.0-dev",
55
"scripts": {
6-
"dev": "next dev --webpack",
7-
"build": "next build --webpack",
6+
"dev": "next dev",
7+
"build": "next build",
88
"start": "next start"
99
},
1010
"dependencies": {

0 commit comments

Comments
 (0)