Skip to content

[BUG] Bright colours incorrectly active in light theme #2509

Description

@j4m3s735

Read the FAQ first

  • I have checked the FAQ but the issue is not covered

Description

After updating I noticed that bright colours are active on light terminal themes. I bisected the cause to 7821552 which swapped the order of initState and defaultConfig.

terminalLightTheme is set in initState, but it is used in defaultConfig, so as it stands options->brightColor will always be set to true.

Version used

2.67.0

Bug prevalence

Always

Regression

Yes

Installation

Built from source

Package manager

No response

Screenshots

No response

Configuration

System information

N/A

Features built-in

N/A

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions