Commit c8a933e
authored
fix: prevent premature draw calls and destroy encoding texture prior to recreation (#208)
* fix: prevent premature `draw()` calls
* fix: destroy the encoding texture before recreating it
In addition, this commit:
- rejects `set()` if the instance was destroyed
- ensures unnecessary texture updates are avoided
- color and encoding textures are destroyed upon calling `scatterplot.destroy()`
- fixes a small memory leak in the newly added advanced exporter where I forgot to unsubscribe a draw listener.
* chore: remove unused `catchError()`1 parent 27ce203 commit c8a933e
File tree
8 files changed
+290
-153
lines changed- src
- tests
8 files changed
+290
-153
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
1 | 9 | | |
2 | 10 | | |
3 | 11 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
172 | 172 | | |
173 | 173 | | |
174 | 174 | | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
0 commit comments