Skip to content

86b7h9kmt - fix: replace hidden html string for empty string #738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
smarcet merged 4 commits into from
Jan 19, 2026
+26 −1
Merged

86b7h9kmt - fix: replace hidden html string for empty string #738

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1b497e8
fix: replace hidden html string for empty string
Dec 24, 2025
0bb6fa4
chore: create helper that covers all cases of empty strings
Jan 19, 2026
2404791
chore: test helper
Jan 19, 2026
a970529
chore: replace validation with the helper
Jan 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/components/inputs/formik-text-editor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import React from "react";
import TextEditorV3 from "openstack-uicore-foundation/lib/components/inputs/editor-input-v3";
import { useFormikContext } from "formik";
import normalizeJoditEmpty from "./utils/normalizeJoditEmpty";

const FormikTextEditor = ({ name, ...props }) => {
const { values, errors, touched, setFieldValue, setFieldTouched } =
Expand All @@ -11,7 +12,11 @@ const FormikTextEditor = ({ name, ...props }) => {
name={name}
id={name}
value={values[name]}
onChange={(e) => setFieldValue(name, e.target.value)}
onChange={(e) => {
Copy link

@smarcet smarcet Jan 19, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@niko-exo seems that comment got truncated
let move this to an util method and lets take care of following corner cases
const normalizeJoditEmpty = (html) => { if (!html) return ""; const v = html.trim(); return (v === "<p><br></p>" || v === "<p><br/></p>" || v === "<p>&nbsp;</p>" || v === "<p></p>") ? "" : html; };

const stringValue = normalizeJoditEmpty(e.target.value);

setFieldValue(name, stringValue);
}}
onBlur={() => setFieldTouched(name, true)}
error={touched?.[name] && errors?.[name] ? errors?.[name] : ""}
license={process.env.JODIT_LICENSE_KEY}
Expand Down
14 changes: 14 additions & 0 deletions src/components/inputs/utils/__tests__/normalizeJoditEmpty.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
import { expect, describe, it } from "@jest/globals";
import normalizeJoditEmpty from "../normalizeJoditEmpty";

describe("normalizeJoditEmpty", () => {
it("normalizes an empty string that is surrounded by html tags", () => {
const inputString = "<p><br></p>";
expect(normalizeJoditEmpty(inputString)).toBe("");
});

it("normalizes a string with content is returned without modifications", () => {
const inputString = "<p>This is a content strign</p>";
expect(normalizeJoditEmpty(inputString)).toBe(inputString);
});
});
6 changes: 6 additions & 0 deletions src/components/inputs/utils/normalizeJoditEmpty.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
const normalizeJoditEmpty = (textInput) => {
const doc = new DOMParser().parseFromString(textInput, "text/html");
return doc.body.textContent.length === 0 ? "" : textInput;
};

export default normalizeJoditEmpty;