Ian/drop existing codegen (#43588)

- I might be missing something, but when doing `npx convex configure` and getting an existing project, I'm not sure codegen is necessary at all, and this can help reduce the number of ways it can be invoked.

This is an alternate to #43587

GitOrigin-RevId: 058fcab33f82b9e379b89fc41d6d5aba82706baf

Author: ianmacartney

src/cli/configure.ts

@@ -41,7 +41,7 @@ import {
 import { writeConvexUrlToEnvFile } from "./lib/envvars.js";
 import path from "path";
 import { projectDashboardUrl } from "./lib/dashboard.js";
-import { doInitialCodegen } from "./lib/codegen.js";
+import { doInitConvexFolder } from "./lib/codegen.js";
 import { handleLocalDeployment } from "./lib/localDeployment/localDeployment.js";
 import {
   promptOptions,
@@ -587,7 +587,7 @@ async function selectNewProject(
     );
   }
 
-  await doInitialCodegen(ctx, { init: true });
+  await doInitConvexFolder(ctx);
   return { teamSlug, projectSlug, devDeployment };
 }
 
@@ -640,9 +640,6 @@ async function selectExistingProject(
         : undefined,
   });
 
-  showSpinner(`Reinitializing project ${projectSlug}...\n`);
-  // TODO: Do we need to do codegen for existing projects? (-Ian)
-  await doInitialCodegen(ctx, { init: false });
   logFinishedStep(`Reinitialized project ${chalkStderr.bold(projectSlug)}`);
   return { teamSlug, projectSlug, devDeployment };
 }

src/cli/lib/codegen.ts

@@ -24,17 +24,13 @@ import {
 } from "../../bundler/log.js";
 import { typeCheckFunctionsInMode, TypeCheckMode } from "./typecheck.js";
 import {
-  configFilepath,
   readProjectConfig,
   usesTypeScriptCodegen,
   usesComponentApiImports,
 } from "./config.js";
 import { recursivelyDelete } from "./fsUtils.js";
 import { componentServerTS } from "../codegen_templates/component_server.js";
-import {
-  ComponentDirectory,
-  isComponentDirectory,
-} from "./components/definition/directoryStructure.js";
+import { ComponentDirectory } from "./components/definition/directoryStructure.js";
 import { StartPushResponse } from "./deployApi/startPush.js";
 import {
   componentApiDTS,
@@ -63,46 +59,26 @@ export type CodegenOptions = {
   codegenOnlyThisComponent?: string | undefined;
 };
 
-export async function doInitialCodegen(
+export async function doInitConvexFolder(
   ctx: Context,
-  options: { init: boolean },
+  functionsFolder?: string,
+  opts?: {
+    dryRun?: boolean;
+    debug?: boolean;
+  },
 ) {
-  const { projectConfig: existingProjectConfig } = await readProjectConfig(ctx);
-  const configPath = await configFilepath(ctx);
-  const functionsPath = functionsDir(configPath, existingProjectConfig);
-  if (options.init) {
-    await doInitCodegen(ctx, functionsPath, true);
-  }
-
-  const componentDir = isComponentDirectory(ctx, functionsPath, true);
-  if (componentDir.kind === "err") {
-    return await ctx.crash({
-      exitCode: 1,
-      errorType: "invalid filesystem data",
-      printedMessage: `Invalid component directory: ${componentDir.why}`,
-    });
-  }
-
-  if (componentDir.component.isRootWithoutConfig) {
-    // Disable typechecking since there isn't any code yet.
-    await doCodegen(ctx, functionsPath, "disable");
+  const skipIfExists = false; // Not currently configured
+  let folder: string;
+  if (functionsFolder) {
+    folder = functionsFolder;
   } else {
-    await withTmpDir(async (tmpDir) => {
-      await doInitialComponentCodegen(ctx, tmpDir, componentDir.component);
-    });
+    const { projectConfig, configPath } = await readProjectConfig(ctx);
+    folder = functionsDir(configPath, projectConfig);
   }
-}
-
-export async function doInitCodegen(
-  ctx: Context,
-  functionsDir: string,
-  skipIfExists: boolean,
-  opts?: { dryRun?: boolean; debug?: boolean },
-): Promise<void> {
-  await prepareForCodegen(ctx, functionsDir, opts);
+  await prepareForCodegen(ctx, folder, opts);
   await withTmpDir(async (tmpDir) => {
-    await doReadmeCodegen(ctx, tmpDir, functionsDir, skipIfExists, opts);
-    await doTsconfigCodegen(ctx, tmpDir, functionsDir, skipIfExists, opts);
+    await doReadmeCodegen(ctx, tmpDir, folder, skipIfExists, opts);
+    await doTsconfigCodegen(ctx, tmpDir, folder, skipIfExists, opts);
   });
 }
 

src/cli/lib/components.ts

@@ -32,7 +32,7 @@ import {
   doFinalComponentCodegen,
   doInitialComponentCodegen,
   CodegenOptions,
-  doInitCodegen,
+  doInitConvexFolder,
   doCodegen,
 } from "./codegen.js";
 import {
@@ -87,7 +87,7 @@ export async function runCodegen(
   const functionsDirectoryPath = functionsDir(configPath, projectConfig);
 
   if (options.init) {
-    await doInitCodegen(ctx, functionsDirectoryPath, false, {
+    await doInitConvexFolder(ctx, functionsDirectoryPath, {
       dryRun: options.dryRun,
       debug: options.debug,
     });

src/cli/lib/localDeployment/anonymous.ts

@@ -43,7 +43,7 @@ import { isAnonymousDeployment } from "../deployment.js";
 import { createProject } from "../api.js";
 import { removeAnonymousPrefix } from "../deployment.js";
 import { nodeFs } from "../../../bundler/fs.js";
-import { doInitialCodegen } from "../codegen.js";
+import { doInitConvexFolder } from "../codegen.js";
 
 export async function handleAnonymousDeployment(
   ctx: Context,
@@ -178,7 +178,7 @@ export async function handleAnonymousDeployment(
   });
 
   if (deployment.kind === "new") {
-    await doInitialCodegen(ctx, { init: true });
+    await doInitConvexFolder(ctx);
   }
   return {
     adminKey,