fixup! feat(navie): differentiate telemetry events by command mode

Author: dividedmind

packages/cli/src/rpc/explain/navie/navie-local.ts

@@ -209,7 +209,7 @@ export default class LocalNavie extends EventEmitter implements INavie {
       // - Separating these prevents pollution of user behavior analytics
       // - All other commands (explain, fix, review, etc.) use the standard navie:response event
       let eventName: string = events.NavieResponse;
-      const commandMode = this.activeNavie?.commandMode;
+      const commandMode = this.activeNavie.commandMode;
       if (commandMode === CommandMode.Welcome) {
         eventName = events.NavieWelcomeResponse;
       } else if (commandMode === CommandMode.Suggest) {

packages/cli/tests/integration/rpc.explain.spec.ts

@@ -6,6 +6,7 @@ import {
   Help,
   navie,
   applyContext,
+  CommandMode,
   Navie,
   TestInvocation,
 } from '@appland/navie';
@@ -71,14 +72,15 @@ describe('RPC', () => {
 
       it('answers the question', async () => {
         jest.spyOn(Telemetry, 'enabled', 'get').mockReturnValue(true);
-        const navieImpl = {
+        const navieImpl: Navie.INavie = {
           on(_event: any, _listener: any) {},
           execute(): AsyncIterable<string> {
             return (async function* () {
               yield answer;
             })();
           },
           terminate: () => false,
+          commandMode: CommandMode.Explain,
         };
 
         jest.mocked(navie).mockReturnValue(navieImpl);

packages/navie/test/navie.spec.ts

@@ -1,49 +1,74 @@
+import { CommandMode } from '../src/command';
 import ExplainCommand from '../src/commands/explain-command';
-import { ContextV2 } from '../src/context';
-import { HelpProvider } from '../src/help';
 import { ClientRequest, NavieOptions, default as navie } from '../src/navie';
-import { ProjectInfoProvider } from '../src/project-info';
-import { TestInvocationProvider } from '../src/test-invocation';
+
+jest.mock('../src/commands/explain-command');
+jest.mock('../src/services/openai-completion-service');
+
+// eslint-disable-next-line @typescript-eslint/require-await
+ExplainCommand.prototype.execute = jest.fn().mockImplementation(async function* () {
+  yield 'This is a test response';
+});
 
 describe('Navie Function', () => {
   let clientRequest: ClientRequest;
-  let contextProvider: ContextV2.ContextProvider;
-  let projectInfoProvider: ProjectInfoProvider;
-  let helpProvider: HelpProvider;
-  let testInvocationProvider: TestInvocationProvider;
-  let options: NavieOptions;
 
-  beforeEach(() => {
-    clientRequest = { question: '' };
-    contextProvider = jest.fn().mockResolvedValue({});
-    projectInfoProvider = jest.fn().mockResolvedValue({});
-    helpProvider = jest.fn().mockResolvedValue({});
-    testInvocationProvider = jest.fn().mockResolvedValue({});
-    options = new NavieOptions();
-  });
+  const createNavie = () => {
+    const contextProvider = jest.fn().mockResolvedValue({});
+    const projectInfoProvider = jest.fn().mockResolvedValue({});
+    const helpProvider = jest.fn().mockResolvedValue({});
+    const testInvocationProvider = jest.fn().mockResolvedValue({});
+    const options = new NavieOptions();
 
-  test('uses default command if question is empty', async () => {
-    const instance = navie(
+    return navie(
       clientRequest,
       contextProvider,
       projectInfoProvider,
       helpProvider,
       testInvocationProvider,
       options
     );
-    const result = [];
-    for await (const chunk of instance.execute()) {
-      result.push(chunk);
-    }
-    expect(result).toBeTruthy();
-    expect(clientRequest.question).toEqual('explain');
+  };
+
+  beforeEach(() => {
+    clientRequest = { question: '' };
   });
-});
 
-jest.mock('../src/commands/explain-command');
-// eslint-disable-next-line @typescript-eslint/require-await
-ExplainCommand.prototype.execute = jest.fn().mockImplementation(async function* () {
-  yield 'This is a test response';
-});
+  describe('commandMode property', () => {
+    test.each([
+      ['empty question', '', CommandMode.Explain],
+      ['no command prefix', 'How does this work?', CommandMode.Explain],
+      ['only whitespace', '   ', CommandMode.Explain],
+      ['@welcome prefix', '@welcome', CommandMode.Welcome],
+      ['@suggest prefix with text', '@suggest What should I do next?', CommandMode.Suggest],
+      ['@suggest prefix alone', '@suggest', CommandMode.Suggest],
+      ['@review prefix', '@review Check this code', CommandMode.Review],
+      [
+        '@review prefix multiline',
+        '@review\nCheck this implementation\nfor potential bugs',
+        CommandMode.Review,
+      ],
+      ['@observe prefix', '@observe What changed?', CommandMode.Observe],
+      ['@fix prefix', '@fix Resolve this issue', CommandMode.Fix],
+      ['@context prefix', '@context Show me relevant files', CommandMode.Context],
+    ])('should set commandMode correctly for %s', (description, question, expectedMode) => {
+      clientRequest.question = question;
+      const instance = createNavie();
+      expect(instance.commandMode).toEqual(expectedMode);
+    });
+  });
 
-jest.mock('../src/services/openai-completion-service');
+  describe('execution', () => {
+    test('executes successfully and normalizes empty question', async () => {
+      clientRequest.question = '';
+      const instance = createNavie();
+      const result = [];
+      for await (const chunk of instance.execute()) {
+        result.push(chunk);
+      }
+      expect(result).toHaveLength(1);
+      expect(result[0]).toBe('This is a test response');
+      expect(clientRequest.question).toBe('explain');
+    });
+  });
+});