Replies: 1 comment
-
|
Now both PRs have been addressed, I'm closing this. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Hi everyone,
Having spent some time trying to understand the Git for Windows installation screens, I tried to clarify two screens that I found confusing, and opened two pull requests on
build-extra:git pullpage. My main confusion was that "Fast-forward" only appeared in the label of the first option, even though the other two also allow a fast-forward internally. So I made "FF" visible in all three labels, added small arrow diagrams to illustrate what each option does, and added a footnote about file conflicts.I recompiled the installer locally via the Git for Windows SDK to verify the rendering.
I thought that for text-only changes, without touching any logic, direct PRs would be the fastest path for maintainers. "Allow edits from maintainers" is enabled on both PRs, so you can directly adjust the wording if you find some additions relevant and not others. If the direction is completely wrong, feel free to close the PRs.
Both PRs have been open for two months with no feedback, and I realize now that I probably should have opened a discussion here beforehand. That's why I'm opening this one — to follow the process and submit my proposals properly.
Thanks for reading!
Beta Was this translation helpful? Give feedback.
All reactions