Why are jsonc keys and values the same color?

[Avasam]

It makes it harder to differentiate keys from values

// Comment is invalid
{
  "foo": "bar",
  "foo2": true,
  "foo3": 3,
}

vs

// Comments are fine
{
  "foo": "bar",
  "foo2": true,
  "foo3": 3,
}

[lildude]

This is a syntax highlighting design question so really should be directed to the upstream maintainers.

From the troubleshooting docs:

There's a problem with the syntax highlighting of a file

Linguist detects the language of a file but the actual syntax-highlighting is powered by a set of language grammars which are included in this project as a set of submodules as listed here.

If you experience an issue with the syntax-highlighting on GitHub, please report the issue to the upstream grammar repository, not here. Grammars are updated every time we build the Linguist gem so upstream bug fixes are automatically incorporated as they are fixed.

[Avasam]

Ah, thanks for the link. There's the issue: JSON with comments is using javascript parsing. So it thinks it's just 2 strings (js string key) and makes no difference.

JSON with Comments: atom/language-javascript

// js
{
  "foo": "bar",
  "foo2": true,
  "foo3": 3,
  valid:"js",
}

// jsonc
{
  "foo": "bar",
  "foo2": true,
  "foo3": 3,
  invalid:"json with comment",
}

// json5
{
  "foo": "bar",
  "foo2": true,
  "foo3": 3,
  valid:"json5",
}

// json
{
  "foo": "bar",
  "foo2": true,
  "foo3": 3,
  invalid:"json",
}

Sidenote, that repo is about to be archived and abandoned in ~2 weeks.

[DecimalTurn]

This issue will be fixed when #7255 is live on GitHub.

[DecimalTurn]

@Avasam, the fix is finally live on GitHub.

@RiskyMH, would you consider switching bun.lock to JSONC now that the syntax highlighting for jsonc code is similar to JSON?

[RiskyMH]

If its the same look, I don't have any issue with it. But just note the only jsonc thing we do there is trailing comma which usually rendering is fine with (it's just parsing that doesn't like), so there isn't too much gain in switching.

On another note, thanks for doing this as it looks awesome for me to use in other places now!

[DecimalTurn]

But just note the only jsonc thing we do there is trailing comma [...]

Ah, that explains why I couldn't find any bun.lock file on GitHub with comments 😅 (search results).

In that case, yeah, there's not much gain from switching at the moment.