G-Code Syntax

[mikecentola]

Hi @lildude I have been getting back into updating some of my projects on here, and I happened to notice that my vscode extension got listed in here for highlighting in GH. I was going to work on some of the things here in linguist specific to g-code, but wanted to get your feedback first.

• The .nc extension is linked to nesC right now. I did a little research and it seems to be a somewhat abandoned language and a quick search on here definitely pulls up more G-Code files. Do you recommend my PR to include removing that from the grammers or just adding the extension to the gcode section?
• My vscode extension covers a fairly wide range of file extensions that I curated from machine tools as well as user submitted ones through issues and PR's. Does it make sense to include the extra extensions and possibly add heuristics to determine it is the correct file?
• Lastly, as I fix things and update the grammar in my extension, how does linguist find the actual JSON file in my repository? Do you recommend that I separately maintain the syntax highlighting grammar in a separate repo?

Looks like I need to submit a PR over at ACE also to update their grammar for g-code.

Thanks!

[lildude]

• Do you recommend my PR to include removing that from the grammers or just adding the extension to the gcode section?

We never remove support for a language or extension so you will need to add it to G-Code, with a heuristic, and samples, assuming the extension meets our usage requirements.

• Does it make sense to include the extra extensions and possibly add heuristics to determine it is the correct file?

Only if they meet our usage requirements. Any extension that doesn't will block the entire PR.

Lastly, as I fix things and update the grammar in my extension, how does linguist find the actual JSON file in my repository?

We expect the grammar file to be in directories specific to the editor they're aimed at. These are the locations we look at:

linguist/tools/grammars/compiler/loader.go

Lines 119 to 128 in 1d913bb

	switch strings.ToLower(ext) {
	case ".plist":
	return strings.HasSuffix(dir, "/Syntaxes")
	case ".tmlanguage", ".yaml-tmlanguage":
	return true
	case ".cson", ".json":
	return strings.HasSuffix(dir, "/grammars") || strings.HasSuffix(dir, "/syntaxes") || GrammarsInNonStdPath[filepath.Base(dir)]
	default:
	return false
	}

• Do you recommend that I separately maintain the syntax highlighting grammar in a separate repo?

That's entirely up to you.

[mikecentola]

@lildude Awesome. Thanks man. Much appreciated. I will get to it.