C++: Remove hasIncompleteSsa and isBusyDef

They are empty now that aliased SSA has been removed.

Author: igfoo

cpp/ql/lib/semmle/code/cpp/ir/implementation/raw/IRFunction.qll

@@ -58,12 +58,4 @@ class IRFunction extends IRFunctionBase {
    * Gets all blocks in this function.
    */
   final IRBlock getABlock() { result.getEnclosingIRFunction() = this }
-
-  /**
-   * Holds if this function may have incomplete def-use information.
-   *
-   * Def-use information may be omitted for a function when it is too expensive
-   * to compute.
-   */
-  final predicate hasIncompleteSsa() { Construction::hasIncompleteSsa(this) }
 }

cpp/ql/lib/semmle/code/cpp/ir/implementation/raw/internal/IRConstruction.qll

@@ -220,8 +220,6 @@ Instruction getMemoryOperandDefinition(
   none()
 }
 
-predicate hasIncompleteSsa(IRFunction f) { none() }
-
 /**
  * Holds if the operand totally overlaps with its definition and consumes the
  * bit range `[startBitOffset, endBitOffset)`.

cpp/ql/lib/semmle/code/cpp/ir/implementation/unaliased_ssa/IRFunction.qll

@@ -58,12 +58,4 @@ class IRFunction extends IRFunctionBase {
    * Gets all blocks in this function.
    */
   final IRBlock getABlock() { result.getEnclosingIRFunction() = this }
-
-  /**
-   * Holds if this function may have incomplete def-use information.
-   *
-   * Def-use information may be omitted for a function when it is too expensive
-   * to compute.
-   */
-  final predicate hasIncompleteSsa() { Construction::hasIncompleteSsa(this) }
 }

cpp/ql/lib/semmle/code/cpp/ir/implementation/unaliased_ssa/internal/SSAConstruction.qll

@@ -473,20 +473,6 @@ private module Cached {
       result = getNewInstruction(oldInstruction)
     )
   }
-
-  /**
-   * Holds if the def-use information for `f` may have been omitted because it
-   * was too expensive to compute. This happens if one of the memory allocations
-   * in `f` is a busy definition (i.e., it has many different overlapping uses).
-   */
-  pragma[nomagic]
-  cached
-  predicate hasIncompleteSsa(IRFunction f) {
-    exists(Alias::MemoryLocation0 defLocation |
-      Alias::isBusyDef(pragma[only_bind_into](defLocation)) and
-      defLocation.getIRFunction() = f
-    )
-  }
 }
 
 private Instruction getNewInstruction(OldInstruction instr) { getOldInstruction(result) = instr }

cpp/ql/lib/semmle/code/cpp/ir/implementation/unaliased_ssa/internal/SimpleSSA.qll

@@ -109,9 +109,3 @@ int getStartBitOffset(MemoryLocation location) { none() }
 
 /** Gets the end bit offset of a `MemoryLocation`, if any. */
 int getEndBitOffset(MemoryLocation location) { none() }
-
-/**
- * Holds if `def` is a busy definition. That is, it has a large number of
- * overlapping uses.
- */
-predicate isBusyDef(MemoryLocation def) { none() }

cpp/ql/lib/semmle/code/cpp/rangeanalysis/new/internal/semantic/SemanticExprSpecific.qll

@@ -114,11 +114,6 @@ module SemanticExprConfig {
   /** Holds if no range analysis should be performed on the phi edges in `f`. */
   private predicate excludeFunction(Cpp::Function f) {
     count(f.getEntryPoint()) > 1
-    or
-    exists(IR::IRFunction irFunction |
-      irFunction.getFunction() = f and
-      irFunction.hasIncompleteSsa()
-    )
   }
 
   SemType getUnknownExprType(Expr expr) { result = getSemanticType(expr.getResultIRType()) }