[Schema Consistency] 🔍 Schema Consistency Check - 2026-08-12 #52243
Closed
Replies: 1 comment
|
This discussion was automatically closed because it expired on 2026-08-13T05:55:22.005Z.
|
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Summary
Critical Issues
pkg/parser/frontmatter.gono longer represents frontmatter parsing behavior, but the task-facing parser file list still points to itpkg/parser/frontmatter.gonow only contains a logger declaration.pkg/workflow/, includingfrontmatter_extraction_yaml.go,frontmatter_types.go, andtrigger_parser.go.pkg/parser/frontmatter.gofor schema consistency will miss the real implementation surface, and automated field-diff approaches that only inspectpkg/parser/*.goproduce false negatives.Auto-generated schema reference omits important schema fields from narrative visibility
docs/src/content/docs/reference/frontmatter-full.mdcontainsallow-bot-authored-trigger-commentandcheck-for-updates, but does not includerun-install-scriptsorreport-failed-jobsas searchable field names.frontmatter.md.Documentation Gaps
frontmatter-full.mdmissesrun-install-scriptsas an actual field pathruntimes.<runtime>.run-install-scriptsexists.pkg/workflow/frontmatter_types.godefinesRunInstallScripts *boolwith JSON tagrun-install-scripts, and validation exists in the workflow layer.frontmatter.mdexplains it, butfrontmatter-full.mdcontains norun-install-scriptstoken at all.frontmatter-full.mdmissesreport-failed-jobsas an actual field pathsafe-outputs.report-failed-jobsexists.pkg/workflow/safe_outputs_config_global.goparsesreport-failed-jobs.frontmatter.mdand glossary mention it, butfrontmatter-full.mddoes not contain the field name.Schema Improvements Needed
Clarify canonical field naming for label-command removal
remove_labelunderon.label_command.remove_labelintentionally uses underscore naming and is notremove-label.Expose nested field coverage better in generated docs
run-install-scriptsandreport-failed-jobs, but the generated reference does not surface them as searchable headings/anchors.Parser Updates Required
Parser ownership/docs need to be updated to reflect reality
pkg/parser/frontmatter.gois effectively a stub.pkg/workflow/frontmatter_extraction_yaml.goandpkg/workflow/trigger_parser.go.pkg/parser, or update docs/tasks/tests that claim parser logic lives there.Field-diff tooling should inspect
pkg/workflow/frontmatter_types.go, not yaml tags inpkg/parser/*.goparser_yaml_fieldswas empty, which is misleading rather than actionable.frontmatter_types.gouses JSON tags for frontmatter keys, e.g.max-daily-ai-credits,runs-on-slim, andcheck-for-updates.Workflow Violations
used_in_workflowsincludes many non-schema keys that are probably body YAML/examples rather than true top-level frontmatternoop,create-pull-request,repo,title,task,try,else.Recommendations
pkg/workflow/instead ofpkg/parser/frontmatter.go.docs/src/content/docs/reference/frontmatter-full.mdso nested schema fields likerun-install-scriptsandreport-failed-jobsare emitted explicitly.frontmatter-full.mdor intentionally excluded.Strategy Performance
Next Steps
All reactions