Upgrade bouncycastle dependencies to 1.72#169
Conversation
Fixes hap-java#80 Succeeds hap-java#146
8e4ccc1 to
8ec6ce6
Compare
|
As Java 8 is targeted: Lines 184 to 185 in 781311e the "jdk18on" artifacts can be used. 🙂 |
|
If I apply this, then the HomeKit add-on won't load in OpenHAB 3.4.0-SNAPSHOT (as of last night), citing |
|
Thanks for having a look! Did you also build an add-on with the changes in openhab/openhab-addons#11104? Those changes are required for embedding bouncycastle 1.72 into the bundle. |
|
I didn't see that PR. I now tried it. I can install the bundle, but logging reports |
|
That's unfortunate since I don't use HomeKit myself so I can't easily test or debug it. 🙁 Do you have an idea what goes wrong? Is there some kind of HomeKit client that can be used for testing? It would be helpful if there were unit tests for testing the crypto logic which would then fail with the upgraded dependencies. Then I could look into fixing those test. 🙂 |
Fixes #80
Succeeds #146
For release notes, see:
https://www.bouncycastle.org/releasenotes.html#r1rv72
Pull Request Checklist
Please confirm that you've done the following when opening a new pull request: