Add support for draft-06/7

[jdesrosiers]

We need to add support for the following keywords to support draft-06.

items - https://json-schema.org/keyword/draft-04/items
additionalItems - https://json-schema.org/keyword/draft-04/additionalItems
dependencies - https://json-schema.org/keyword/draft-04/dependencies
contains - https://json-schema.org/keyword/draft-06/contains

[Adityakumar37]

@jdesrosiers could you please explain this issue

[srivastava-diya]

Hi @jdesrosiers ,
I’ve already been working on the overlapping draft-04 keywords (items, additionalItems, dependencies) and added test coverage and handlers around those areas.
Since draft-06 follows much of the same behavior (except contains as it involves references), I’d be happy to work on this issue if that sounds good to you.

[Adityakumar37]

@srivastava-diya i would like to work with you

[jdesrosiers]

I just created a bunch of new issues. @srivastava-diya can you take #133 next because you implemented that in draft-1 and you already know all complexities involved.

Then, @Adityakumar37, you can take this one. It should be pretty trivial, just a copy of the current contains handlers and remove the minContains/maxContains stuff.

[jdesrosiers]

Also, I'm going to add draft-07 in scope for this issue because there are no more new keywords to implement once contains is done.

[Adityakumar37]

Hi @jdesrosiers, thanks for assigning the next draft-06 keywords.

I’ll take care of the draft-06/07 support.
As you mentioned, I’ll implement it by copying the existing contains normalization/error handler and adjusting it for draft-06/07 by removing the minContains / maxContains behavior.

[Adityakumar37]

Hi @jdesrosiers before I go further, I wanted to quickly check if my current approach for draft-06/07 contains is on the right track.
Right now I’ve

Added a draft-specific normalization handler under normalization-handlers/draft-06/contains.js
Registered it for

https://json-schema.org/keyword/draft-06/contains
https://json-schema.org/keyword/draft-07/contains
Simplified the logic so it only enforces the draft-06 semantics (at least one matching item, no minContains/maxContains support

One thing I’m unsure about is whether I should be doing anything more than this, especially

1. should I avoid creating any new error handler and just reuse the existing one?
2. And should the tests just be mappings of the existing contains tests with "compatibility": "6"?
   Just wanted to confirm this matches what you expect before I push changes. Thanks!

[jdesrosiers]

Added a draft-specific normalization handler under normalization-handlers/draft-06/contains.js

👍

Registered it for

https://json-schema.org/keyword/draft-06/contains
https://json-schema.org/keyword/draft-07/contains

Not quite. You only need to register https://json-schema.org/keyword/draft-06/contains. It's the same keyword in draft-06 and draft-07 so they have the same keyword URI.

Simplified the logic so it only enforces the draft-06 semantics (at least one matching item, no minContains/maxContains support

👍

1. should I avoid creating any new error handler and just reuse the existing one?

It's probably possible to reuse the existing one in this case. I'll leave it up to to you to explore that option and decide whether to reuse or create a new one. I don't have strong feelings either way at this point.

2. And should the tests just be mappings of the existing contains tests with "compatibility": "6"?

I don't think you need to add or change any tests for this one. There's enough overlap with the current contains that the existing tests already cover this case. The compatibility is already to set properly to run the tests that are relevant for draft-06 and draft-07. The one's with "compatibility": 6 are the ones that will run with your new handlers.