Added downgrade sets for Rector, targetting PHP 7.4 and Symfony 5

Author: mnocon

.github/workflows/code_samples.yaml

@@ -8,6 +8,7 @@ jobs:
         name: Validate code samples
         runs-on: "ubuntu-22.04"
         strategy:
+            fail-fast: false
             matrix:
                 php:
                     - "8.4" # Upper supported version
@@ -47,6 +48,12 @@ jobs:
 
             - name: Run PHPStan analysis
               run: composer phpstan
+  
+            - if: matrix.php == '8.4' # ibexa/rector supports PHP 8.3 and higher
+              name: Run Rector check
+              run: |
+                composer require --dev ibexa/rector:~4.6.x-dev
+                composer check-rector
 
     code-samples-inclusion-check:
         name: Check code samples inclusion

composer.json

@@ -11,6 +11,9 @@
             "url": "https://updates.ibexa.co"
         }
     ],
+    "require": {
+        "php": "^7.4 || ^8.0"
+    },
     "require-dev": {
         "ibexa/automated-translation": "4.6.x-dev",
         "ibexa/code-style": "^1.0",
@@ -82,7 +85,14 @@
     "scripts": {
         "fix-cs": "php-cs-fixer fix --config=.php-cs-fixer.php -v --show-progress=dots",
         "check-cs": "@fix-cs --dry-run",
-        "phpstan": "phpstan analyse"
+        "phpstan": "phpstan analyse",
+         "check-rector": "rector process --dry-run --ansi"
+    },
+    "suggest": {
+        "ibexa/rector": "Add Rector to check for code refactoring opportunities"
+    },
+    "scripts-descriptions": {
+         "check-rector": "Check for code refactoring opportunities"
     },
     "config": {
         "allow-plugins": false

rector.php

@@ -0,0 +1,27 @@
+<?php
+
+/**
+ * @copyright Copyright (C) Ibexa AS. All rights reserved.
+ * @license For full copyright and license information view LICENSE file distributed with this source code.
+ */
+declare(strict_types=1);
+
+use Rector\Config\RectorConfig;
+use Ibexa\Contracts\Rector\Sets\IbexaSetList;
+use Rector\Symfony\DowngradeSymfony70\Rector\Class_\DowngradeSymfonyCommandAttributeRector;
+use Rector\DowngradePhp82\Rector\FuncCall\DowngradeIteratorCountToArrayRector;
+
+return RectorConfig::configure()
+    ->withPaths([
+        __DIR__ . '/code_samples',
+    ])
+    ->withSkip([
+        DowngradeIteratorCountToArrayRector::class,
+    ])
+    ->withSets([
+        IbexaSetList::IBEXA_46->value,
+    ])
+    ->withDowngradeSets(php74: true)
+    ->withRules([
+        DowngradeSymfonyCommandAttributeRector::class,
+    ]);