From c6a2abf9c68d1b5479fdba375a872920cd745269 Mon Sep 17 00:00:00 2001 From: init4samwise Date: Thu, 12 Feb 2026 20:03:05 +0000 Subject: [PATCH 1/4] chore: add PR template Closes ENG-1818 --- .github/PULL_REQUEST_TEMPLATE.md | 68 ++++++++++++++++++++++++++++++++ 1 file changed, 68 insertions(+) create mode 100644 .github/PULL_REQUEST_TEMPLATE.md diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md new file mode 100644 index 00000000..a789c415 --- /dev/null +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -0,0 +1,68 @@ +## Description + + + +## Related Issue + + +Closes ENG-XXXX + +## Type of Change + +- [ ] Bug fix (non-breaking change that fixes an issue) +- [ ] New feature (non-breaking change that adds functionality) +- [ ] Breaking change (fix or feature that would cause existing functionality to change) +- [ ] Refactoring (no functional changes) +- [ ] Documentation update +- [ ] CI/CD or tooling changes + +## Changes Made + + + +- + +## Testing + + + +- [ ] Unit tests pass (`cargo test`) +- [ ] Integration tests pass (if applicable) +- [ ] Manual testing performed +- [ ] New tests added for new functionality + +## Builder-Specific Checklist + + + +- [ ] Block construction logic is correct +- [ ] Transaction ordering/prioritization changes are intentional +- [ ] MEV considerations reviewed (if applicable) +- [ ] Performance impact assessed for hot paths +- [ ] RPC endpoint changes documented (if applicable) + +## Code Quality + +- [ ] Code follows the project's style guidelines +- [ ] Self-review completed +- [ ] Comments added for complex logic +- [ ] No unnecessary debug/print statements +- [ ] Error handling is appropriate + +## Documentation + +- [ ] README updated (if needed) +- [ ] API documentation updated (if applicable) +- [ ] CHANGELOG updated (if applicable) + +## Pre-Submit Checklist + +- [ ] `cargo fmt --check` passes +- [ ] `cargo clippy` passes without warnings +- [ ] All CI checks pass +- [ ] Branch is up to date with main + +## Additional Notes + + + From b0040343e065b541a902ffca24e355d4404fbc74 Mon Sep 17 00:00:00 2001 From: init4samwise Date: Fri, 13 Feb 2026 19:43:06 +0000 Subject: [PATCH 2/4] chore: use make targets in PR template per review feedback --- .github/PULL_REQUEST_TEMPLATE.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index a789c415..78b48b5e 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -57,8 +57,8 @@ Closes ENG-XXXX ## Pre-Submit Checklist -- [ ] `cargo fmt --check` passes -- [ ] `cargo clippy` passes without warnings +- [ ] `make fmt` passes +- [ ] `make clippy` passes - [ ] All CI checks pass - [ ] Branch is up to date with main From 208bcbec6ba854ccd623f0f3692d28e5ae3fbee9 Mon Sep 17 00:00:00 2001 From: init4samwise Date: Mon, 16 Feb 2026 23:02:06 +0000 Subject: [PATCH 3/4] Simplify PR template --- .github/PULL_REQUEST_TEMPLATE.md | 64 ++------------------------------ 1 file changed, 4 insertions(+), 60 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 78b48b5e..f48aacd0 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,68 +1,12 @@ ## Description - + ## Related Issue - -Closes ENG-XXXX - -## Type of Change - -- [ ] Bug fix (non-breaking change that fixes an issue) -- [ ] New feature (non-breaking change that adds functionality) -- [ ] Breaking change (fix or feature that would cause existing functionality to change) -- [ ] Refactoring (no functional changes) -- [ ] Documentation update -- [ ] CI/CD or tooling changes - -## Changes Made - - - -- + ## Testing - - -- [ ] Unit tests pass (`cargo test`) -- [ ] Integration tests pass (if applicable) -- [ ] Manual testing performed -- [ ] New tests added for new functionality - -## Builder-Specific Checklist - - - -- [ ] Block construction logic is correct -- [ ] Transaction ordering/prioritization changes are intentional -- [ ] MEV considerations reviewed (if applicable) -- [ ] Performance impact assessed for hot paths -- [ ] RPC endpoint changes documented (if applicable) - -## Code Quality - -- [ ] Code follows the project's style guidelines -- [ ] Self-review completed -- [ ] Comments added for complex logic -- [ ] No unnecessary debug/print statements -- [ ] Error handling is appropriate - -## Documentation - -- [ ] README updated (if needed) -- [ ] API documentation updated (if applicable) -- [ ] CHANGELOG updated (if applicable) - -## Pre-Submit Checklist - -- [ ] `make fmt` passes -- [ ] `make clippy` passes -- [ ] All CI checks pass -- [ ] Branch is up to date with main - -## Additional Notes - - - +- [ ] Tests pass locally +- [ ] New tests added (if applicable) From dbdd12d03ae904cef6976baf0c8c884813acecd3 Mon Sep 17 00:00:00 2001 From: init4samwise Date: Mon, 2 Mar 2026 21:30:58 +0000 Subject: [PATCH 4/4] chore: add make fmt, clippy, test checks to PR template --- .github/PULL_REQUEST_TEMPLATE.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index f48aacd0..8b44e221 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -8,5 +8,7 @@ ## Testing -- [ ] Tests pass locally +- [ ] `make fmt` passes +- [ ] `make clippy` passes +- [ ] `make test` passes - [ ] New tests added (if applicable)