Plugin not working with Corsair H100i v2 due to version naming

[0LGuenth]

Hello,
I'm trying to use your plugin with my Corsair H100i v2. To me the problems seems to be the version naming. In the error log it throws the following error:

Newtonsoft.Json.JsonReaderException: Could not convert string to double: 2.8.0.0. Path '[0].status[3].value', line 1, position 294.
bei Newtonsoft.Json.JsonReader.ReadDoubleString(String s)
bei Newtonsoft.Json.JsonTextReader.FinishReadQuotedNumber(ReadType readType)
bei Newtonsoft.Json.JsonTextReader.ReadAsDouble()
bei Newtonsoft.Json.JsonReader.ReadForType(JsonContract contract, Boolean hasConverter)
bei Newtonsoft.Json.Serialization.JsonSerializerInternalReader.PopulateObject(Object newObject, JsonReader reader, JsonObjectContract contract, JsonProperty member, String id)
bei Newtonsoft.Json.Serialization.JsonSerializerInternalReader.CreateObject(JsonReader reader, Type objectType, JsonContract contract, JsonProperty member, JsonContainerContract containerContract, JsonProperty containerMember, Object existingValue)
bei Newtonsoft.Json.Serialization.JsonSerializerInternalReader.CreateValueInternal(JsonReader reader, Type objectType, JsonContract contract, JsonProperty member, JsonContainerContract containerContract, JsonProperty containerMember, Object existingValue)
bei Newtonsoft.Json.Serialization.JsonSerializerInternalReader.PopulateList(IList list, JsonReader reader, JsonArrayContract contract, JsonProperty containerProperty, String id)
bei Newtonsoft.Json.Serialization.JsonSerializerInternalReader.CreateList(JsonReader reader, Type objectType, JsonContract contract, JsonProperty member, Object existingValue, String id)
bei Newtonsoft.Json.Serialization.JsonSerializerInternalReader.CreateValueInternal(JsonReader reader, Type objectType, JsonContract contract, JsonProperty member, JsonContainerContract containerContract, JsonProperty containerMember, Object existingValue)
bei Newtonsoft.Json.Serialization.JsonSerializerInternalReader.SetPropertyValue(JsonProperty property, JsonConverter propertyConverter, JsonContainerContract containerContract, JsonProperty containerProperty, JsonReader reader, Object target)
bei Newtonsoft.Json.Serialization.JsonSerializerInternalReader.PopulateObject(Object newObject, JsonReader reader, JsonObjectContract contract, JsonProperty member, String id)
bei Newtonsoft.Json.Serialization.JsonSerializerInternalReader.CreateObject(JsonReader reader, Type objectType, JsonContract contract, JsonProperty member, JsonContainerContract containerContract, JsonProperty containerMember, Object existingValue)
bei Newtonsoft.Json.Serialization.JsonSerializerInternalReader.CreateValueInternal(JsonReader reader, Type objectType, JsonContract contract, JsonProperty member, JsonContainerContract containerContract, JsonProperty containerMember, Object existingValue)
bei Newtonsoft.Json.Serialization.JsonSerializerInternalReader.PopulateList(IList list, JsonReader reader, JsonArrayContract contract, JsonProperty containerProperty, String id)
bei Newtonsoft.Json.Serialization.JsonSerializerInternalReader.CreateList(JsonReader reader, Type objectType, JsonContract contract, JsonProperty member, Object existingValue, String id)
bei Newtonsoft.Json.Serialization.JsonSerializerInternalReader.CreateValueInternal(JsonReader reader, Type objectType, JsonContract contract, JsonProperty member, JsonContainerContract containerContract, JsonProperty containerMember, Object existingValue)
bei Newtonsoft.Json.Serialization.JsonSerializerInternalReader.Deserialize(JsonReader reader, Type objectType, Boolean checkAdditionalContent)
bei Newtonsoft.Json.JsonSerializer.DeserializeInternal(JsonReader reader, Type objectType)
bei Newtonsoft.Json.JsonConvert.DeserializeObject(String value, Type type, JsonSerializerSettings settings)
bei Newtonsoft.Json.JsonConvert.DeserializeObject[T](String value, JsonSerializerSettings settings)
bei FanControl.Liquidctl.LiquidctlCLIWrapper.ReadStatus()
bei FanControl.Liquidctl.LiquidctlPlugin.Load(IPluginSensorsContainer _container)
bei FanControl.Domain.BackendProviders.Plugin.PluginBackendProvider.Open()

[SuspiciousActivity]

This seems like it's the same problem that @kromosomX (tagging you here because the other issue was closed) had here. You could give my fork a try if you want, the issue with the Firmware version should be fixed there as well now.

[hmm-norah]

@SuspiciousActivity I have the same Asetek as kromosomX but unfortunately your fork doesn't seem to avoid the crash, and I wonder if it's because the firmware version is being reported in a different place than FIBSensei (above). Without knowing if the fix works for FIBSensei though, I can't be sure.

I cloned your fork and have been looking around a bit to see if I can understand what's going on, but my knowledge is very basic. What I can do however, is post my json report as well as error message in case this helps narrow it down to a universal solution. If you end up taking a look and would like any more info, please let me know.

CLI:

C:\Program Files (x86)\Fan Control\Plugins>liquidctl -d 1 --json interactive
WARNING: python -m liquidctl.cli is deprecated, prefer python -m liquidctl
WARNING: -d/--device is deprecated, prefer --match or other selection options
status
{"status": "success", "data": [{"bus": "usb1", "address": 18, "description": "Asetek 690LC (assuming EVGA CLC)", "status": [{"key": "Liquid temperature", "value": 27.0, "unit": "°C"}, {"key": "Fan speed", "value": 720, "unit": "rpm"}, {"key": "Pump speed", "value": 2820, "unit": "rpm"}, {"key": "Firmware version", "value": "2.10.0.0", "unit": ""}]}]}

Formatted JSON:

{
	"status": "success",
	"data": [{
		"bus": "usb1",
		"address": 18,
		"description": "Asetek 690LC (assuming EVGA CLC)",
		"status": [{
			"key": "Liquid temperature",
			"value": 27.0,
			"unit": "°C"
		}, {
			"key": "Fan speed",
			"value": 720,
			"unit": "rpm"
		}, {
			"key": "Pump speed",
			"value": 2820,
			"unit": "rpm"
		}, {
			"key": "Firmware version",
			"value": "2.10.0.0",
			"unit": ""
		}]
	}]
}

Fan Control\log.txt

3/24/2023 5:17:47 PM: Newtonsoft.Json.JsonReaderException: Could not convert string to double: 2.10.0.0. Path '[1].status[3].value', line 1, position 590.
   at Newtonsoft.Json.JsonReader.ReadDoubleString(String s)
   at Newtonsoft.Json.JsonTextReader.FinishReadQuotedNumber(ReadType readType)
   at Newtonsoft.Json.JsonTextReader.ReadAsDouble()
   at Newtonsoft.Json.JsonReader.ReadForType(JsonContract contract, Boolean hasConverter)
   at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.PopulateObject(Object newObject, JsonReader reader, JsonObjectContract contract, JsonProperty member, String id)
   at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.CreateObject(JsonReader reader, Type objectType, JsonContract contract, JsonProperty member, JsonContainerContract containerContract, JsonProperty containerMember, Object existingValue)
   at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.CreateValueInternal(JsonReader reader, Type objectType, JsonContract contract, JsonProperty member, JsonContainerContract containerContract, JsonProperty containerMember, Object existingValue)
   at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.PopulateList(IList list, JsonReader reader, JsonArrayContract contract, JsonProperty containerProperty, String id)
   at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.CreateList(JsonReader reader, Type objectType, JsonContract contract, JsonProperty member, Object existingValue, String id)
   at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.CreateValueInternal(JsonReader reader, Type objectType, JsonContract contract, JsonProperty member, JsonContainerContract containerContract, JsonProperty containerMember, Object existingValue)
   at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.SetPropertyValue(JsonProperty property, JsonConverter propertyConverter, JsonContainerContract containerContract, JsonProperty containerProperty, JsonReader reader, Object target)
   at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.PopulateObject(Object newObject, JsonReader reader, JsonObjectContract contract, JsonProperty member, String id)
   at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.CreateObject(JsonReader reader, Type objectType, JsonContract contract, JsonProperty member, JsonContainerContract containerContract, JsonProperty containerMember, Object existingValue)
   at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.CreateValueInternal(JsonReader reader, Type objectType, JsonContract contract, JsonProperty member, JsonContainerContract containerContract, JsonProperty containerMember, Object existingValue)
   at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.PopulateList(IList list, JsonReader reader, JsonArrayContract contract, JsonProperty containerProperty, String id)
   at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.CreateList(JsonReader reader, Type objectType, JsonContract contract, JsonProperty member, Object existingValue, String id)
   at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.CreateValueInternal(JsonReader reader, Type objectType, JsonContract contract, JsonProperty member, JsonContainerContract containerContract, JsonProperty containerMember, Object existingValue)
   at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.Deserialize(JsonReader reader, Type objectType, Boolean checkAdditionalContent)
   at Newtonsoft.Json.JsonSerializer.DeserializeInternal(JsonReader reader, Type objectType)
   at Newtonsoft.Json.JsonConvert.DeserializeObject(String value, Type type, JsonSerializerSettings settings)
   at Newtonsoft.Json.JsonConvert.DeserializeObject[T](String value, JsonSerializerSettings settings)
   at FanControl.Liquidctl.LiquidctlCLIWrapper.ReadStatus()
   at FanControl.Liquidctl.LiquidctlPlugin.Load(IPluginSensorsContainer _container)
   at FanControl.Domain.BackendProviders.Plugin.PluginBackendProvider.Open()

[SuspiciousActivity]

@hmm-norah did you also use the newest version of my fork of the plugin? Because that error cannot come from my fork anymore, I moved the code that tries to convert the firmware version to a number to another place. Could you check if the plugin dll in your plugins folder is the same as the one in my latest release? Also, did you restart FanControl after you copied my fork?

[levvp]

@SuspiciousActivity
My NZXT fan controller works with liquidctl, supplied by your fork.
For example, I can run "liquidctl status" and get a list of ans and their speeds.
However, in FanControl I only get a message "LiquidctlPlugin could not initialize or has no sensors".
Here is the log:
FanControl Log

[SuspiciousActivity]

@levvp did you use my liquidctl.exe together with my FanControl.LiquidctlPlugin? My liquidctl.exe doesn't work with the original plugin, only with my fork. That's because its based on a newer version of liquidctl, which added support for some other stuff that the original plugin cannot handle, but mine can.

[realgooseman]

Hi @SuspiciousActivity

First of all thanks for your fork, I confirm that your v1.0.1 LiquidCtl plugin works for my Kraken Z53 pump control but doesn't seem to detect my NZXT RGB & Fan Controller. Also it works perfectly on startup but for some reason the plugin crashes and shows and error when the computer is coming out of sleep mode. Is it an error you're aware of ?

[levvp]

@SuspiciousActivity Just to make sure, I've just stopped FanControl, replaced the files in the "Plugins" folder again from the release ZIP file, then started FanControl again.
Interestingly, now FanControl log shows no errors - only the line:
3/25/2023 5:19:51 PM: LiquidctlPlugin could not initialize or has no sensors.

[SuspiciousActivity]

@realgooseman I don't know of any error when coming out of sleep mode. Can you tell me what the error is? Does the log.txt file in FanControl's folder have some more information? Does your RGB & Fan Controller show up when you run liquidctl.exe list or liquidctl.exe status in the Plugins folder? (I've just realized the LiquidctlPlugin only monitors pump speeds and liquid temperatures, the Fan Controller should show up without the plugin, or FanControl just doesn't support it yet)

[hmm-norah]

In doing a complete reinstall to weed out having made a mistake like the non-forked dll being loaded I have updated to v152 which seems to be having its own issues. Once I figure that out I will report back, but I will likely need to make a new issue regarding v152 on the FanControl page.

I was building your fork myself, but I can't say confidently enough that I was closing it because I keep forgetting even now that it hides in the task bar. Launching the exe when it's already running just opens the already-running program, and it's completely possible that I was tricking myself into thinking it was a new launch.

[realgooseman]

@realgooseman I don't know of any error when coming out of sleep mode. Can you tell me what the error is? Does the log.txt file in FanControl's folder have some more information? Does your RGB & Fan Controller show up when you run liquidctl.exe list or liquidctl.exe status in the Plugins folder? (I've just realized the LiquidctlPlugin only monitors pump speeds and liquid temperatures, the Fan Controller should show up without the plugin, or FanControl just doesn't support it yet)

Here's how the plugin behaves in my particular case :

• The Plugin works great on startup
• The plugin crashes after the computer comes out of sleep mode
• After the crash, when closing FanControl and restarting it the plugin works again
• I disabled and uninstalled all interfering software and added a startup delay

Here are the different pop-ups and errors I'm getting when it crashes :

Here is the log text for the error :

25/03/2023 23:09:38: Unhandled exception in FanControl v1.0.0.0
25/03/2023 23:09:38: System.ArgumentNullException: La valeur ne peut pas être null.
Nom du paramètre : s
à System.IO.StringReader..ctor(String s)
à Newtonsoft.Json.Linq.JObject.Parse(String json, JsonLoadSettings settings)
à FanControl.Liquidctl.LiquidctlCLIWrapper.ReadStatus(String address)
à FanControl.Liquidctl.LiquidctlDevice.LoadJSON()
à FanControl.Liquidctl.LiquidctlPlugin.Update()
à FanControl.Domain.BackendProviders.Plugin.PluginBackendProvider.Update()
à System.Collections.Generic.List1.ForEach(Action1 action)
à FanControl.Domain.ComputerAccessLayer.Update()
à FanControl.Domain.ApplicationClock.DoActions()
--- Fin de la trace de la pile à partir de l'emplacement précédent au niveau duquel l'exception a été levée ---
à System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
à System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Int32 numArgs)
à System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Int32 numArgs, Delegate catchHandler)
25/03/2023 23:09:39: System.Exception: liquidctl returned non-zero exit code 1. Last stderr output:
WARNING: python -m liquidctl.cli is deprecated, prefer python -m liquidctl
OSError: [WinError 6] Descripteur non valide
[4436] Failed to execute script 'cli' due to unhandled exception!

à FanControl.Liquidctl.LiquidctlCLIWrapper.LiquidctlCall(String arguments)
à FanControl.Liquidctl.LiquidctlPlugin.Initialize()
à FanControl.Domain.BackendProviders.Plugin.PluginBackendProvider.Open()
25/03/2023 23:09:49: System.Exception: liquidctl returned non-zero exit code 1. Last stderr output:
WARNING: python -m liquidctl.cli is deprecated, prefer python -m liquidctl
OSError: [WinError 6] Descripteur non valide
[8196] Failed to execute script 'cli' due to unhandled exception!

à FanControl.Liquidctl.LiquidctlCLIWrapper.LiquidctlCall(String arguments)
à FanControl.Liquidctl.LiquidctlPlugin.Initialize()
à FanControl.Domain.BackendProviders.Plugin.PluginBackendProvider.Open()
25/03/2023 23:09:55: System.Exception: liquidctl returned non-zero exit code 1. Last stderr output:
WARNING: python -m liquidctl.cli is deprecated, prefer python -m liquidctl
OSError: [WinError 6] Descripteur non valide
[4288] Failed to execute script 'cli' due to unhandled exception!

à FanControl.Liquidctl.LiquidctlCLIWrapper.LiquidctlCall(String arguments)
à FanControl.Liquidctl.LiquidctlPlugin.Initialize()
à FanControl.Domain.BackendProviders.Plugin.PluginBackendProvider.Open()
25/03/2023 23:10:02: System.Exception: liquidctl returned non-zero exit code 1. Last stderr output:
WARNING: python -m liquidctl.cli is deprecated, prefer python -m liquidctl
OSError: [WinError 6] Descripteur non valide
[12420] Failed to execute script 'cli' due to unhandled exception!

à FanControl.Liquidctl.LiquidctlCLIWrapper.LiquidctlCall(String arguments)
à FanControl.Liquidctl.LiquidctlPlugin.Initialize()
à FanControl.Domain.BackendProviders.Plugin.PluginBackendProvider.Open()
25/03/2023 23:10:08: System.Exception: liquidctl returned non-zero exit code 1. Last stderr output:
WARNING: python -m liquidctl.cli is deprecated, prefer python -m liquidctl
OSError: [WinError 6] Descripteur non valide
[13504] Failed to execute script 'cli' due to unhandled exception!

à FanControl.Liquidctl.LiquidctlCLIWrapper.LiquidctlCall(String arguments)
à FanControl.Liquidctl.LiquidctlPlugin.Initialize()
à FanControl.Domain.BackendProviders.Plugin.PluginBackendProvider.Open()
25/03/2023 23:10:15: System.Exception: liquidctl returned non-zero exit code 1. Last stderr output:
WARNING: python -m liquidctl.cli is deprecated, prefer python -m liquidctl
OSError: [WinError 6] Descripteur non valide
[7980] Failed to execute script 'cli' due to unhandled exception!

à FanControl.Liquidctl.LiquidctlCLIWrapper.LiquidctlCall(String arguments)
à FanControl.Liquidctl.LiquidctlPlugin.Initialize()
à FanControl.Domain.BackendProviders.Plugin.PluginBackendProvider.Open()
25/03/2023 23:10:15: LiquidctlPlugin could not initialize or has no sensors.

If the error is not known, is there something I'm doing wrong ?

[hmm-norah]

This is the same error that I seem to be receiving as well once adding the files to the Plugins folder, FanControl runs perfectly for me until then. I recorded a video on a clean setup and verified that I am running the fork including the fork's liquidctl.exe. The only difference I can see between mine and realgooseman's is that I don't receive an error about restoring the configuration because I did not have one set up using the plugin to begin with.

https://streamable.com/td764k

log.txt

liquidctl output:

PS C:\Users\Norah\Desktop\fancontrol152net7\Plugins> .\liquidctl.exe --version
liquidctl v0.0.0-unknown (Windows-10-10.0.22621-SP0)
PS C:\Users\Norah\Desktop\fancontrol152net7\Plugins> .\liquidctl.exe -d 1 --json interactive
WARNING: python -m liquidctl.cli is deprecated, prefer python -m liquidctl
WARNING: -d/--device is deprecated, prefer --match or other selection options
status
{"status": "success", "data": [{"bus": "usb1", "address": 25, "description": "Asetek 690LC (assuming EVGA CLC)", "status": [{"key": "Liquid temperature", "value": 27.4, "unit": "°C"}, {"key": "Fan speed", "value": 720, "unit": "rpm"}, {"key": "Pump speed", "value": 2820, "unit": "rpm"}, {"key": "Firmware version", "value": "2.10.0.0", "unit": ""}]}]}

[SuspiciousActivity]

Alright @realgooseman and @hmm-norah I've made a new version of both the plugin and liquidctl (ZIP here). Hopefully it fixes something, if not, there should be some new output in the log.txt.
To @levvp and @realgooseman, this plugin was never meant to support the NZXT Fan Controller, or any fan controller really. It only reads pump speeds and liquid temperatures. I don't have one, so I can't really talk about it a lot, but I thought FanControl itself would handle them. So if your fan controller is not there, FanControl just doesn't support it yet.

[realgooseman]

Alright @realgooseman and @hmm-norah I've made a new version of both the plugin and liquidctl (ZIP here). Hopefully it fixes something, if not, there should be some new output in the log.txt. To @levvp and @realgooseman, this plugin was never meant to support the NZXT Fan Controller, or any fan controller really. It only reads pump speeds and liquid temperatures. I don't have one, so I can't really talk about it a lot, but I thought FanControl itself would handle them. So if your fan controller is not there, FanControl just doesn't support it yet.

Just tried and it works like before but still shows similar errors when the pc boots out of sleep mode.

New log.txt here

[hmm-norah]

Looks to be loading now with a new error, GUI repeats error in a similar way to the video I attached further up.

log.txt

Interesting to see the message about python making its way into the log. I have a second device that shows up in liquidctl as well (has always been there but didn't think to mention it), not sure if that would help to pinpoint what's going on. Non-json status command:

PS C:\Users\Norah\Desktop\fancontrol152net7\Plugins> ./liquidctl.exe status
WARNING: python -m liquidctl.cli is deprecated, prefer python -m liquidctl
ASUS Aura LED Controller (experimental)
├── ARGB channels: 2
└──  RGB channels: 1

Asetek 690LC (assuming EVGA CLC)
├── Liquid temperature        24.9  °C
├── Fan speed                  660  rpm
├── Pump speed                2850  rpm
└── Firmware version      2.10.0.0

result of --json list and --json status

PS C:\Users\Norah\Desktop\fancontrol152net7\Plugins> ./liquidctl.exe --json list
WARNING: python -m liquidctl.cli is deprecated, prefer python -m liquidctl
[{"description": "ASUS Aura LED Controller", "vendor_id": 2821, "product_id": 6575, "release_number": 256, "serial_number": "9876543210", "bus": "hid", "address": "\\\\?\\HID#VID_0B05&PID_19AF&MI_02#7&382c88b3&0&0000#{4d1e55b2-f16f-11cf-88cb-001111000030}", "port": null, "driver": "AuraLed", "experimental": true}, {"description": "Asetek 690LC (assuming EVGA CLC)", "vendor_id": 9267, "product_id": 45568, "release_number": 256, "serial_number": "CCVI_1.0", "bus": "usb1", "address": 4, "port": [11], "driver": "Modern690Lc", "experimental": false}]

PS C:\Users\Norah\Desktop\fancontrol152net7\Plugins> ./liquidctl.exe --json status
WARNING: python -m liquidctl.cli is deprecated, prefer python -m liquidctl
[{"bus": "hid", "address": "\\\\?\\HID#VID_0B05&PID_19AF&MI_02#7&382c88b3&0&0000#{4d1e55b2-f16f-11cf-88cb-001111000030}", "description": "ASUS Aura LED Controller", "status": [{"key": "ARGB channels: 2", "value": "", "unit": ""}, {"key": " RGB channels: 1", "value": "", "unit": ""}]}, {"bus": "usb1", "address": 4, "description": "Asetek 690LC (assuming EVGA CLC)", "status": [{"key": "Liquid temperature", "value": 24.9, "unit": "°C"}, {"key": "Fan speed", "value": 660, "unit": "rpm"}, {"key": "Pump speed", "value": 2850, "unit": "rpm"}, {"key": "Firmware version", "value": "2.10.0.0", "unit": ""}]}]