Return no browser on pool acquire timeout

Author: Sayan-

src/kernel/_response.py

@@ -16,6 +16,7 @@
     Iterator,
     AsyncIterator,
     cast,
+    get_args,
     overload,
 )
 from typing_extensions import Awaitable, ParamSpec, override, get_origin
@@ -185,6 +186,8 @@ def _parse(self, *, to: type[_T] | None = None) -> R | _T:
             return cast(R, None)
 
         response = self.http_response
+        if response.status_code == 204 and NoneType in get_args(cast_to):
+            return cast(R, None)
         if cast_to == str:
             return cast(R, response.text)
 

src/kernel/resources/browser_pools.py

@@ -542,7 +542,7 @@ def acquire(
         extra_query: Query | None = None,
         extra_body: Body | None = None,
         timeout: float | httpx.Timeout | None | NotGiven = not_given,
-    ) -> BrowserPoolAcquireResponse:
+    ) -> Optional[BrowserPoolAcquireResponse]:
         """Long-polling endpoint to acquire a browser from the pool.
 
         Returns immediately
@@ -607,7 +607,7 @@ def acquire(
             options=make_request_options(
                 extra_headers=extra_headers, extra_query=extra_query, extra_body=extra_body, timeout=timeout
             ),
-            cast_to=BrowserPoolAcquireResponse,
+            cast_to=Optional[BrowserPoolAcquireResponse],
         )
 
     def flush(
@@ -1199,7 +1199,7 @@ async def acquire(
         extra_query: Query | None = None,
         extra_body: Body | None = None,
         timeout: float | httpx.Timeout | None | NotGiven = not_given,
-    ) -> BrowserPoolAcquireResponse:
+    ) -> Optional[BrowserPoolAcquireResponse]:
         """Long-polling endpoint to acquire a browser from the pool.
 
         Returns immediately
@@ -1264,7 +1264,7 @@ async def acquire(
             options=make_request_options(
                 extra_headers=extra_headers, extra_query=extra_query, extra_body=extra_body, timeout=timeout
             ),
-            cast_to=BrowserPoolAcquireResponse,
+            cast_to=Optional[BrowserPoolAcquireResponse],
         )
 
     async def flush(