Skip to content

Commit d387aab

Browse files
feat: Fix 1Password fill classification for repeat fills and unconfirmed submits
Stainless-Generated-From: 399a7000e4351b576352ac5a8772b7dc28a15682
1 parent 31b7bda commit d387aab

2 files changed

Lines changed: 11 additions & 9 deletions

File tree

‎src/kernel/types/vaults/credential_vault_item_request_param.py‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,8 @@ class CredentialVaultItemRequestParam(TypedDict, total=False):
1515
If they choose 1Password, connect their account and request access to a login
1616
in their own non-shared vault; passkeys are not supported. If they decline
1717
or that path fails, collect a Kernel-hosted credential item instead. Never
18-
automatically retry an uncertain 1Password request or fill.
18+
automatically retry an uncertain 1Password request. After an uncertain fill,
19+
inspect the page to see the result of the fill.
1920
Do not use credential items for credit card data. Use wallet and card item types instead.
2021
Kernel credentials declare fields and may enter pending_collection.
2122
1Password credentials either reference a connected credential_account or

‎src/kernel/types/vaults/one_password_fill_vault_item_operation_result.py‎

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -18,19 +18,20 @@ class OnePasswordFillVaultItemOperationResult(BaseModel):
1818
"""Kernel's outcome of the extension call.
1919
2020
fill_submitted means the extension reported submission, not website
21-
authentication. fill_failed means the extension returned a known failure and may
22-
include error_code. fill_unknown means submission may have happened without a
23-
conclusive response; it has no error_code and must not be retried in the same
24-
browser.
21+
authentication. fill_failed means the extension returned a known failure and
22+
includes error_code. fill_unknown means the form may have been filled or
23+
submitted without a conclusive result; inspect the page to see the result of the
24+
fill.
2525
"""
2626

2727
type: Literal["1pw_fill"]
2828

2929
error_code: Optional[Literal["fillFailed", "autosubmitFailed", "noExistingCredentials", "authenticationFailed"]] = (
3030
None
3131
)
32-
"""Present only for a conclusive fill_failed response.
33-
34-
These are allowlisted 1Password extension codes, never raw errors, secrets, or
35-
page content.
32+
"""
33+
Present for fill_failed, and for fill_unknown when the extension reported
34+
autosubmitFailed (it filled and submitted the form but could not confirm the
35+
fill finished). These are allowlisted 1Password extension codes, never raw
36+
errors, secrets, or page content.
3637
"""

0 commit comments

Comments
 (0)