conformance: add a conformance test for BackendTLSPolicy

Changing a ConfigMap content should be reconciled by the controller.

Author: Ali Syed

conformance/tests/backendtlspolicy.go

@@ -17,8 +17,13 @@ limitations under the License.
 package tests
 
 import (
+	"context"
 	"testing"
 
+	"github.com/stretchr/testify/require"
+	corev1 "k8s.io/api/core/v1"
+	"sigs.k8s.io/controller-runtime/pkg/client"
+
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/types"
 
@@ -152,5 +157,100 @@ var BackendTLSPolicy = suite.ConformanceTest{
 					},
 				})
 		})
+
+		// Verify that changing a ConfigMap content should be reconciled by the controller
+		t.Run("Changing the content of a ConfigMap should be reconciled by the controller", func(t *testing.T) {
+			ctx, cancel := context.WithTimeout(context.Background(), suite.TimeoutConfig.DefaultTestTimeout)
+			defer cancel()
+			routeNN := types.NamespacedName{Name: "backendtlspolicy", Namespace: ns}
+			gwNN := types.NamespacedName{Name: "same-namespace", Namespace: ns}
+			validconfigmap := types.NamespacedName{Name: "tls-checks-ca-certificate", Namespace: ns}
+			invalidconfigmap := types.NamespacedName{Name: "mismatch-ca-certificate", Namespace: ns}
+
+			kubernetes.NamespacesMustBeReady(t, suite.Client, suite.TimeoutConfig, []string{ns})
+			gwAddr := kubernetes.GatewayAndRoutesMustBeAccepted(t, suite.Client, suite.TimeoutConfig, suite.ControllerName, kubernetes.NewGatewayRef(gwNN), &gatewayv1.HTTPRoute{}, false, routeNN)
+			kubernetes.HTTPRouteMustHaveResolvedRefsConditionsTrue(t, suite.Client, suite.TimeoutConfig, routeNN, gwNN)
+
+			validPolicyNN := types.NamespacedName{Name: "normative-test", Namespace: ns}
+			kubernetes.BackendTLSPolicyMustHaveCondition(t, suite.Client, suite.TimeoutConfig, validPolicyNN, gwNN, acceptedCond)
+			kubernetes.BackendTLSPolicyMustHaveCondition(t, suite.Client, suite.TimeoutConfig, validPolicyNN, gwNN, resolvedRefsCond)
+
+			validcm := &corev1.ConfigMap{}
+			err := suite.Client.Get(ctx, validconfigmap, validcm)
+			require.NoErrorf(t, err, "failed to get valid configmap")
+
+			invalidcm := &corev1.ConfigMap{}
+			err = suite.Client.Get(ctx, invalidconfigmap, invalidcm)
+			require.NoErrorf(t, err, "failed to get invalid configmap")
+
+			originalCAData := validcm.Data["ca.crt"]
+			mismatchCAData := invalidcm.Data["ca.crt"]
+
+			t.Cleanup(func() {
+				cleanupCtx, cleanupCancel := context.WithTimeout(context.Background(),
+					suite.TimeoutConfig.DefaultTestTimeout)
+				defer cleanupCancel()
+
+				currentCM := &corev1.ConfigMap{}
+				err = suite.Client.Get(cleanupCtx, validconfigmap, currentCM)
+				if err != nil {
+					t.Logf("cleanup: error getting ConfigMap: %v", err)
+					return
+				}
+
+				if currentCM.Data["ca.crt"] != originalCAData {
+					restored := currentCM.DeepCopy()
+					restored.Data["ca.crt"] = originalCAData
+					err = suite.Client.Patch(cleanupCtx, restored, client.MergeFrom(currentCM))
+					if err != nil {
+						t.Logf("cleanup: error restoring ConfigMap: %v", err)
+					}
+				}
+			})
+			h.MakeRequestAndExpectEventuallyConsistentResponse(t, suite.RoundTripper, suite.TimeoutConfig, gwAddr,
+				h.ExpectedResponse{
+					Namespace: ns,
+					Request: h.Request{
+						Host: "abc.example.com",
+						Path: "/backendtlspolicy",
+					},
+					Response: h.Response{StatusCodes: []int{200}},
+				})
+
+			mutatedCM := validcm.DeepCopy()
+			mutatedCM.Data["ca.crt"] = mismatchCAData
+			err = suite.Client.Patch(ctx, mutatedCM, client.MergeFrom(validcm))
+			require.NoErrorf(t, err, "failed to mutate ConfigMap")
+
+			h.MakeRequestAndExpectFailure(t, suite.RoundTripper, suite.TimeoutConfig, gwAddr,
+				h.ExpectedResponse{
+					Namespace: ns,
+					Request: h.Request{
+						Host: "abc.example.com",
+						Path: "/backendtlspolicy",
+						SNI:  "abc.example.com",
+					},
+				})
+
+			currentCM := &corev1.ConfigMap{}
+			err = suite.Client.Get(ctx, validconfigmap, currentCM)
+			require.NoErrorf(t, err, "failed to get valid configmap")
+
+			restoredCM := currentCM.DeepCopy()
+			restoredCM.Data["ca.crt"] = originalCAData
+			err = suite.Client.Patch(ctx, restoredCM, client.MergeFrom(currentCM))
+			require.NoErrorf(t, err, "failed to mutate ConfigMap")
+
+			h.MakeRequestAndExpectEventuallyConsistentResponse(t, suite.RoundTripper, suite.TimeoutConfig, gwAddr,
+				h.ExpectedResponse{
+					Namespace: ns,
+					Request: h.Request{
+						Host: "abc.example.com",
+						Path: "/backendtlspolicy",
+						SNI:  "abc.example.com",
+					},
+					Response: h.Response{StatusCodes: []int{200}},
+				})
+		})
 	},
 }