You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: geps/gep-2162/index.md
+3-3Lines changed: 3 additions & 3 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -28,7 +28,7 @@ This GEP proposes to enhance the [GatewayClassStatus](https://github.com/kuberne
28
28
29
29
The current [GatewayClassStatus](https://github.com/kubernetes-sigs/gateway-api/blob/f2cd9bb92b4ff392416c40d6148ff7f76b30e649/apis/v1beta1/gatewayclass_types.go#L185) is only used to store conditions the controller publishes.
30
30
31
-
Partnered with the [Conformance Profiles](https://github.com/kubernetes-sigs/gateway-api/blob/main/geps/gep-1709.md) work, we want to:
31
+
Partnered with the [Conformance Profiles](/geps/gep-1709/) work, we want to:
32
32
33
33
1. Improve UX by enabling users to easily see what features the implementation(GatewayClass) support.
34
34
1. Standardize features and conformance tests names.
@@ -162,15 +162,15 @@ Before we make the changes we need to;
162
162
163
163
### Re-using ConformanceProfiles structs
164
164
165
-
We could use the same structs as we do in conformance profile object, more specifically, the [ProfileReport](https://github.com/kubernetes-sigs/gateway-api/blob/main/conformance/apis/v1alpha1/profilereport.go#LL24C6-L24C19) struct.
165
+
We could use the same structs as we do in conformance profile object, more specifically, the [ProfileReport](https://github.com/kubernetes-sigs/gateway-api/blob/main/conformance/apis/v1/conformancereport.go#LL28C6-L28C19) struct.
166
166
167
167
Though it would be nice to have only one place to update, these structs seems to include much more data relevant to the conformance report but not for our use case.
168
168
169
169
That said, conformance profiles are still at experimental stage, we could explore the option to create a shared struct that will be used both for the conformance reports and for the GatewayClass status.
170
170
171
171
### Instruct users to read from the future conformance profiles report
172
172
173
-
The current plan for conformance profiles is to also include centralized reporting. (more info in [gep-1709](https://github.com/kubernetes-sigs/gateway-api/blob/main/geps/gep-1709.md))
173
+
The current plan for conformance profiles is to also include centralized reporting. (more info in [gep-1709](/geps/gep-1709/))
174
174
We could wait for this to be implemented and instruct users to read from that source to determine what features their installed GatewayClass support.
175
175
176
176
However, having the supported features published in the GatewayClass Status adds the following values:
Copy file name to clipboardExpand all lines: hack/mkdocs/generate.sh
+1-2Lines changed: 1 addition & 2 deletions
Original file line number
Diff line number
Diff line change
@@ -43,8 +43,7 @@ for i in "${arr[@]}"; do
43
43
tmpdir=$(mktemp -d --tmpdir=${PWD}/tmp)
44
44
45
45
git fetch ${REMOTE}${i}||
46
-
echo"You need a git remote pointing to upstream for API Ref generation.";
47
-
echo"To solve this issue locally, execute 'git remote add upstream [email protected]:kubernetes-sigs/gateway-api.git' and then call the script again with 'REMOTE=upstream <command>'"
46
+
echo"You need a git remote pointing to upstream for API Ref generation. To solve this issue locally, execute 'git remote add upstream [email protected]:kubernetes-sigs/gateway-api.git' and then call the script again with 'REMOTE=upstream <command>'"
0 commit comments