Conversation
Member
|
Hi can you get rid of the .pyc file please? That's probably an artifact from you (or maybe an ai agent) executing the code in-tree. |
Hypnotix embeds mpv's x11 video window via wid. Under XWayland that window takes key presses before the GTK window, so on_key_press_event never runs and shortcuts (f/F11, F6, F7, Esc, Up/Down, Ctrl+R...) do nothing while a stream is playing. Disable input_vo_keyboard only when XDG_SESSION_TYPE is "wayland". on_key_press_event already forwards unhandled keys to mpv with the "keypress" command, so mpv's default bindings keep working. X11 sessions are unchanged.
xreed88
force-pushed
the
fix/wayland-keyboard-shortcuts
branch
from
September 26, 2026 00:18
b2c56ed to
44ecd93
Compare
Author
|
Done, the .pyc is gone. The PR is back to a single commit that only touches |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In a Wayland session, Hypnotix's keyboard shortcuts stop working while a stream is playing. That covers
f/F11 (fullscreen), F6, F7, Esc, Backspace, ↑/↓ (channel switching) and Ctrl+R/Ctrl+F.Hypnotix embeds mpv's video window through
widwithvo=x11, so under Wayland that window runs through XWayland. Withinput_vo_keyboard=True, the embedded mpv window takes key presses before the GTK window, soon_key_press_eventnever runs.Fix
input_vo_keyboardis nowFalseonly whenXDG_SESSION_TYPEiswayland:Truethere.on_key_press_eventalready forwards every key it doesn't handle to mpv with thekeypresscommand, so keys like space,mand9/0keep working through that path.Testing
input_vo_keyboard=False, the shortcuts above work during playback. Hyprland putsXDG_SESSION_TYPE=waylandin the environment that launched apps get.Truethere, which is the current behavior.🤖 Generated with Claude Code