Skip to content

Triage 9 pre-existing bug-test fixtures failing mxcli check #571

@ako

Description

@ako

After extending `make check-mdl` to cover `mdl-examples/bug-tests/` (commit 05fc1d3), 9 fixtures fail `mxcli check` and are currently skipped via a deny-list in the Makefile to keep CI green.

The failures are heterogeneous. Each needs individual triage:

Fixture Likely cause
`116-datagrid2-column-name-mismatch.mdl` Parse errors (syntax may demonstrate the bug intentionally)
`343-list-attribute-find-filter.mdl` Probably needs project context (Attribute paths)
`352-java-action-return-type-inference.mdl` Probably needs project context (Java action signature)
`352-retrieve-compact-reverse-association.mdl` Probably needs project context (association paths)
`360-import-mapping-result-type.mdl` Probably needs project context (mapping result type)
`367-retrieve-sort-indirect-entity-ref.mdl` Probably needs project context (sort path)
`369-rest-mapping-result-cardinality.mdl` Probably needs project context (REST mapping)
`373-change-action-items-storage-list.mdl` Probably needs project context (entity attributes)
`552-npe-reserved-words.mdl` Negative test — validator MUST fire on reserved-word attrs

Work

For each fixture:

  1. Run `mxcli check` and triage the failure mode
  2. If it requires a project, decide whether to run it with `-p ... --references` against a fixture project, or whether the fixture is genuinely demonstrating something `mxcli check` can't validate standalone
  3. If it's a negative test (552), update the Makefile to invert the exit code expectation — these should fail check and be reported as PASS
  4. If it's a "demonstrate broken syntax" fixture, consider splitting the bug demo (broken) from a fixed example (clean) so CI can cover the post-fix state

Once each is triaged and either fixed or properly categorized, remove its entry from the SKIP list in the Makefile's `check-mdl` target.

Acceptance

  • All 9 fixtures removed from the SKIP list in `Makefile`
  • `make check-mdl` covers them with appropriate semantics (positive or negative)
  • No regression in coverage of other doctype-tests / bug-tests

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions