fix: address Copilot review comments

- setup.py: filter find_packages to exclude build_ddbc from wheel
- build_backend.py: add _is_truthy() for PEP 517 config_settings boolean coercion
- test_001_globals.py: clean up test_windows_x64_detection (remove dead reload/patch)

Author: bewithgaurav

build_ddbc/build_backend.py

@@ -23,6 +23,19 @@
 from .compiler import compile_ddbc
 
 
+def _is_truthy(value):
+    """Convert a config_settings value to a boolean.
+
+    PEP 517 frontends pass config_settings values as strings (e.g., "true"),
+    not Python booleans. This helper normalises them.
+    """
+    if isinstance(value, bool):
+        return value
+    if isinstance(value, str):
+        return value.lower() in ("true", "1", "yes")
+    return bool(value)
+
+
 # =============================================================================
 # PEP 517 Required Hooks
 # =============================================================================
@@ -55,7 +68,7 @@ def build_wheel(wheel_directory, config_settings=None, metadata_directory=None):
     # Check if we should skip compilation (e.g., for sdist-only builds)
     skip_compile = False
     if config_settings:
-        skip_compile = config_settings.get("--skip-ddbc-compile", False)
+        skip_compile = _is_truthy(config_settings.get("--skip-ddbc-compile", False))
 
     if not skip_compile:
         # Extract build options from config_settings
@@ -64,7 +77,7 @@ def build_wheel(wheel_directory, config_settings=None, metadata_directory=None):
 
         if config_settings:
             arch = config_settings.get("--arch")
-            coverage = config_settings.get("--coverage", False)
+            coverage = _is_truthy(config_settings.get("--coverage", False))
 
         print("[build_backend] Compiling ddbc_bindings...")
         try:

setup.py

@@ -22,15 +22,14 @@
 
 from mssql_python.platform_utils import get_platform_info
 
-
 # =============================================================================
 # Platform-Specific Package Discovery
 # =============================================================================
 
 
 def get_platform_packages():
     """Get platform-specific package list."""
-    packages = find_packages()
+    packages = find_packages(include=["mssql_python", "mssql_python.*"])
     arch, _ = get_platform_info()
 
     if sys.platform.startswith("win"):

tests/test_001_globals.py

@@ -781,27 +781,13 @@ def test_get_platform_info_current_platform(self):
     def test_windows_x64_detection(self):
         """Test Windows x64 platform detection."""
         from unittest.mock import patch
+        from mssql_python import platform_utils
 
-        with (
-            patch("mssql_python.platform_utils.sys") as mock_sys,
-            patch("mssql_python.platform_utils.os") as mock_os,
-        ):
-            mock_sys.platform = "win32"
-            mock_os.environ.get.return_value = "x64"
-
-            from mssql_python import platform_utils
-
-            # Force reimport to pick up mocked values
-            import importlib
-
-            importlib.reload(platform_utils)
-
-            # Restore for actual test
-            with patch.object(platform_utils.sys, "platform", "win32"):
-                with patch.object(platform_utils.os.environ, "get", return_value="x64"):
-                    arch, tag = platform_utils.get_platform_info()
-                    assert arch == "x64"
-                    assert tag == "win_amd64"
+        with patch.object(platform_utils.sys, "platform", "win32"):
+            with patch.object(platform_utils.os.environ, "get", return_value="x64"):
+                arch, tag = platform_utils.get_platform_info()
+                assert arch == "x64"
+                assert tag == "win_amd64"
 
     def test_windows_x86_detection(self):
         """Test Windows x86 platform detection."""