-
Notifications
You must be signed in to change notification settings - Fork 152
Open
Description
Look at the diff below, created by dotnet format
var content = await response.Content.ReadAsStringAsync();
- AssertSuccess(response, content);
+ await AssertSuccessAsync(response, content);
return Deserialize<BidResponsePayload>(content);
The methods in question:
private async Task AssertSuccessAsync(HttpResponseMessage response)
{
AssertSuccess(response, await response.Content.ReadAsStringAsync());
}
private void AssertSuccess(HttpResponseMessage response, string content)
{
if (!response.IsSuccessStatusCode)
{
_logger.LogError("Failed with response: {}", content);
throw new HttpRequestException();
}
}Looks to me like the fixer sees that the code is in a async context and there is a async method of AssertSuccess available. No consideration is taken that the arguments match
Code is VSTHRD103
Version:
~/dev/checkwattapi(cleanup/dotnet-format)$ dotnet --info
.NET SDK:
Version: 8.0.400
Commit: 36fe6dda56
Workload version: 8.0.400-manifests.6356aace
MSBuild version: 17.11.3+0c8610977
Runtime Environment:
OS Name: ubuntu
OS Version: 22.04
OS Platform: Linux
RID: linux-x64
Base Path: /home/tobbe/.dotnet/sdk/8.0.400/
.NET workloads installed:
Configured to use loose manifests when installing new manifests.
There are no installed workloads to display.
Host:
Version: 9.0.0
Architecture: x64
Commit: 9d5a6a9aa4
.NET SDKs installed:
6.0.400 [/home/tobbe/.dotnet/sdk]
8.0.400 [/home/tobbe/.dotnet/sdk]
9.0.100 [/home/tobbe/.dotnet/sdk]
.NET runtimes installed:
Microsoft.AspNetCore.App 6.0.8 [/home/tobbe/.dotnet/shared/Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 8.0.8 [/home/tobbe/.dotnet/shared/Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 9.0.0 [/home/tobbe/.dotnet/shared/Microsoft.AspNetCore.App]
Microsoft.NETCore.App 6.0.8 [/home/tobbe/.dotnet/shared/Microsoft.NETCore.App]
Microsoft.NETCore.App 8.0.8 [/home/tobbe/.dotnet/shared/Microsoft.NETCore.App]
Microsoft.NETCore.App 9.0.0 [/home/tobbe/.dotnet/shared/Microsoft.NETCore.App]
Other architectures found:
None
Environment variables:
DOTNET_ROOT [/home/tobbe/.dotnet]
global.json file:
/home/tobbe/dev/checkwattapi/global.json
Learn more:
https://aka.ms/dotnet/info
Download .NET:
https://aka.ms/dotnet/download
Metadata
Metadata
Assignees
Labels
No labels