fix(everything): reject HTTP error responses in gzip-file-as-resource - #4953
Open
kabishou11 wants to merge 1 commit into
Open
kabishou11 wants to merge 1 commit into
kabishou11 wants to merge 1 commit into
Conversation
fetchSafely only checked that a body was present, so a 404 or 500 page was compressed and returned as if it were the requested file.
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
gzip-file-as-resourcecompresses whatever body the URL returns, including HTTP error pages.fetchSafelyonly checks thatresponse.bodyexists and never looks atresponse.ok. A 404 or 500 response therefore comes back as a normalapplication/gzipresource whose contents are the server's error page.This change checks
response.okbefore reading. If the response is not OK, it cancels the unread body and throwsFailed to fetch <url>: status <code>, the same way the tool already reports other fetch failures.Server Details
gzip-file-as-resource)Motivation and Context
Before (local HTTP server serving 200 / 404 / 500):
After:
How Has This Been Tested?
should reject HTTP error responses instead of compressing the error pageinsrc/everything/__tests__/tools.test.ts. It starts a local HTTP server on 127.0.0.1 and checks the 200, 404 and 500 cases. It fails onmainand passes with this change.vitest runinsrc/everything: 110 passed.tsc --noEmit: clean.Breaking Changes
None. Successful responses are handled exactly as before.
Types of changes
Checklist
Additional context
This is separate from the open SSRF and redirect PRs for this tool (#4498, #4622), which deal with which hosts may be fetched, not with the response status.