Merge pull request #372 from mozilla/settings-label

bakulf · web-flow · commit b820ce82d27d · 2019-08-09T14:42:37.000+03:00
Adding in aria-label for settings button. Fixes #370
diff --git a/src/_locales/en_US/messages.json b/src/_locales/en_US/messages.json
@@ -56,7 +56,10 @@
     "message": "Powered by Cloudflare®."
   },
   "popupToggleButton": {
-    "message": "Firefox Private Network "
+    "message": "Firefox Private Network"
+  },
+  "popupSettingsButtonLabel": {
+    "message": "Settings"
   },
 
   "toastProxyOff": {
diff --git a/src/view.js b/src/view.js
@@ -70,6 +70,7 @@ export class View {
 
   static showSettings(shouldShow) {
     let settingsElement = document.getElementById("settingsButton");
+    settingsElement.setAttribute("aria-label", currentView.getTranslation("popupSettingsButtonLabel"));
     settingsElement.toggleAttribute("hidden", !shouldShow);
   }
 

Original file line number	Diff line number	Diff line change
`@@ -70,6 +70,7 @@ export class View {`
`70`	`70`
`71`	`71`	`static showSettings(shouldShow) {`
`72`	`72`	`let settingsElement = document.getElementById("settingsButton");`
	`73`	`+ settingsElement.setAttribute("aria-label", currentView.getTranslation("popupSettingsButtonLabel"));`
`73`	`74`	`settingsElement.toggleAttribute("hidden", !shouldShow);`
`74`	`75`	`}`
`75`	`76`