Hani/test addressbar bookmarks when history disabled (#925)

* Test addressbar bookmarks when history disabled

* add .ymal

* edit methods

* one method instead of two

* remove all.ymal and functional.ymal

---------

Co-authored-by: Hani Yacoub <[email protected]>

Author: sv-hyacoub

SELECTOR_INFO.md

@@ -1243,6 +1243,13 @@ Description: The Restore Default Search Engines button under Search shortcuts ta
 Location: about:preferences#search Search Shortcuts subsection
 Path to .json: modules/data/about_prefs.components.json
 ```
+```
+Selector Name: Browsing History
+Selector Data: history-suggestion
+Description: Browsing History / History Suggestion under Address bar section
+Location: about:preferences#search 
+Path to .json: modules/data/about_prefs.components.json
+```
 #### about_profiles
 ```
 Selector Name: profile-container

manifests/key.yaml

@@ -20,6 +20,10 @@ address_bar_and_search:
     splits:
     - smoke
     - ci-extended
+  test_addressbar_bookmarks_when_history_disabled:
+    result: pass
+    splits:
+      - functional1
   test_addressbar_search_engine_keywords:
     result: pass
     splits:

modules/browser_object_navigation.py

@@ -1085,3 +1085,48 @@ def click_exit_button_searchmode(self) -> None:
 
         # Click the button
         self.get_element("exit-button-searchmode").click()
+
+    @BasePage.context_chrome
+    def type_and_verify(
+            self,
+            input_text: str,
+            expected_text: str,
+            timeout: float = 5.0,
+            click: bool = True,  # If True: click match; else: return index
+    ) -> int | bool:
+        """
+        Types into the awesome bar, waits for a suggestion containing `expected_text`.
+
+        If `click=True` (default):
+            - Click the matching element and return True
+            - Raises if not found (test fails)
+
+        If `click=False`:
+            - Return the 0-based index of the matching element
+            - Raises if not found (test fails)
+        """
+
+        # Reset + type
+        self.clear_awesome_bar()
+        self.type_in_awesome_bar(input_text)
+
+        def find_match(driver):
+            suggestions = self.get_all_children("results-dropdown")
+
+            for index, s in enumerate(suggestions):
+                try:
+                    if expected_text in s.text:
+                        return (s, index)
+                except StaleElementReferenceException:
+                    continue
+
+            return False  # keep polling
+
+        # No try/except here — failure = real failure
+        element, index = self.custom_wait(timeout=timeout).until(find_match)
+
+        if click:
+            element.click()
+            return True
+
+        return index

modules/data/about_prefs.components.json

@@ -612,6 +612,10 @@
     "groups": [
       "doNotCache"
     ]
+  },
+  "history-suggestion": {
+    "selectorData": "historySuggestion",
+    "strategy": "id",
+    "groups": []
   }
-
 }

modules/page_object_prefs.py

@@ -805,6 +805,14 @@ def open_manage_cookies_data_dialog(self) -> BasePage:
         BrowserActions(self.driver).switch_to_iframe_context(manage_data_popup)
         return self
 
+    def uncheck_history_suggestion(self):
+        """
+        Uncheck the 'historySuggestion' checkbox if it's currently checked.
+        """
+        checkbox = self.get_element("history-suggestion")
+        if checkbox.is_selected():
+            checkbox.click()
+
 
 class AboutAddons(BasePage):
     """

tests/address_bar_and_search/test_addressbar_bookmarks_when_history_disabled.py

@@ -0,0 +1,47 @@
+import pytest
+from selenium.webdriver import Firefox
+
+from modules.browser_object_navigation import Navigation
+from modules.browser_object_tabbar import TabBar
+from modules.page_object_prefs import AboutPrefs
+
+
+@pytest.fixture()
+def test_case():
+    return "3028908"
+
+
+def test_addressbar_bookmarks_when_history_disabled(driver: Firefox):
+    """
+    C3028908 - Most relevant bookmarks are shown in the address bar even when history is disabled
+    """
+
+    # Instantiate objects
+    nav = Navigation(driver)
+    tabs = TabBar(driver)
+    about_prefs = AboutPrefs(driver, category="search")
+
+    # In addressbar press z and pick "Get Involved" page
+    nav.type_and_verify("z", "Get Involved", click=True)
+
+    # Repeat step from above
+    tabs.new_tab_by_button()
+    nav.type_and_verify("z", "Get Involved", click=True)
+
+    # On z press check "Get Involved" page is shown as the first result
+    tabs.new_tab_by_button()
+    position = nav.type_and_verify("z", "Get Involved", click=False)
+    assert position == 1
+
+    # Navigate to about:preferences and uncheck Browsing History
+    tabs.new_tab_by_button()
+    driver.switch_to.window(driver.window_handles[-1])
+    about_prefs.open()
+    about_prefs.uncheck_history_suggestion()
+
+    # Open a new tab and press z
+    tabs.new_tab_by_button()
+
+    # Check "Get Involved" page is shown as the first result
+    position = nav.type_and_verify("z", "Get Involved", click=False)
+    assert position == 1