Skip to content

Commit c2186c8

Browse files
committed
refactor: inline type import
1 parent 72e7dad commit c2186c8

File tree

2 files changed

+3
-7
lines changed

2 files changed

+3
-7
lines changed

src/generators/web/ui/components/AnnouncementBanner/loadBanners.mjs

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,13 @@
11
import { isBannerActive } from '../../utils/banner.mjs';
22

3-
/** @import { BannerEntry, RemoteConfig } from './types.d.ts' */
4-
53
/**
64
* Fetches and returns active banners for the given version.
75
* Returns an empty array when remoteConfig is absent, the response is not ok,
86
* or on any fetch/parse failure.
97
*
108
* @param {string | undefined} remoteConfig
119
* @param {number | null} versionMajor
12-
* @returns {Promise<BannerEntry[]>}
10+
* @returns {Promise<import('./types.d.ts').BannerEntry[]>}
1311
*/
1412
export const loadBanners = async (remoteConfig, versionMajor) => {
1513
if (!remoteConfig) {
@@ -19,7 +17,7 @@ export const loadBanners = async (remoteConfig, versionMajor) => {
1917
try {
2018
const res = await fetch(remoteConfig);
2119

22-
/** @type {RemoteConfig} */
20+
/** @type {import('./types.d.ts').RemoteConfig} */
2321
const { websiteBanners = {} } = await res.json();
2422

2523
const keys = ['index', versionMajor != null && `v${versionMajor}`].filter(

src/generators/web/ui/utils/banner.mjs

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,9 @@
1-
/** @import { BannerEntry } from '../components/AnnouncementBanner/types' */
2-
31
/**
42
* Checks whether a banner should be displayed based on its date range.
53
* Both `startDate` and `endDate` are optional; if omitted the banner is
64
* considered open-ended in that direction.
75
*
8-
* @param {BannerEntry} banner
6+
* @param {import('../components/AnnouncementBanner/types').BannerEntry} banner
97
* @returns {boolean}
108
*/
119
export const isBannerActive = ({ startDate, endDate }) => {

0 commit comments

Comments
 (0)