Skip to content

Commit e2bc24c

Browse files
committed
Revert "stream: noop pause/resume on destroyed streams"
This reverts commit 29b1966.
1 parent f05a61d commit e2bc24c

2 files changed

Lines changed: 0 additions & 16 deletions

File tree

lib/internal/streams/readable.js

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1233,9 +1233,6 @@ function nReadingNextTick(self) {
12331233
// If the user uses them, then switch into old mode.
12341234
Readable.prototype.resume = function() {
12351235
const state = this._readableState;
1236-
if ((state[kState] & kDestroyed) !== 0) {
1237-
return this;
1238-
}
12391236
if ((state[kState] & kFlowing) === 0) {
12401237
debug('resume');
12411238
// We flow only if there is no one listening
@@ -1276,9 +1273,6 @@ function resume_(stream, state) {
12761273

12771274
Readable.prototype.pause = function() {
12781275
const state = this._readableState;
1279-
if ((state[kState] & kDestroyed) !== 0) {
1280-
return this;
1281-
}
12821276
debug('call pause');
12831277
if ((state[kState] & (kHasFlowing | kFlowing)) !== kHasFlowing) {
12841278
debug('pause');

test/parallel/test-stream-destroy.js

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -118,13 +118,3 @@ const http = require('http');
118118
req.end('asd');
119119
}));
120120
}
121-
122-
{
123-
// resume() and pause() should be no-ops on destroyed streams.
124-
const r = new Readable({ read() {} });
125-
r.destroy();
126-
r.on('resume', common.mustNotCall());
127-
r.on('pause', common.mustNotCall());
128-
r.resume();
129-
r.pause();
130-
}

0 commit comments

Comments
 (0)