From d4068ecfc2a417a63aa5c41d15d5ce22ab0820f2 Mon Sep 17 00:00:00 2001 From: Stewart X Addison Date: Tue, 13 Jan 2026 15:42:42 +0000 Subject: [PATCH 1/2] doc: note resume build should not be done on node-test-commit Signed-off-by: Stewart X Addison --- doc/contributing/collaborator-guide.md | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/doc/contributing/collaborator-guide.md b/doc/contributing/collaborator-guide.md index 23b5a53a91e49d..598daa950df8bf 100644 --- a/doc/contributing/collaborator-guide.md +++ b/doc/contributing/collaborator-guide.md @@ -267,12 +267,14 @@ If there are GitHub Actions CI failures unrelated to the change in the pull request, try the "๐Ÿ”„ Re-run all jobs" button, on the right-hand side of the "Checks" tab. -If there are Jenkins CI failures unrelated to the change in the pull request, -try "Resume Build". It is in the left navigation of the relevant -`node-test-pull-request` job. It will preserve all the green results from the -current job but re-run everything else. Start a fresh CI by pressing "Retry" -if more than seven days have elapsed since the original failing CI as the -compiled binaries for the Windows and ARM platforms are only kept for seven days. +If there are Jenkins CI failures unrelated to the change in the pull +request, try "Resume Build". It is in the left navigation of the relevant +`node-test-pull-request` job (Do not be tempted to do this on the lower +level `node-test-commit` job as it will not report the updated result back +to the PR). It will preserve all the green results from the current job but +re-run everything else. Start a fresh CI by pressing "Retry" if more than +seven days have elapsed since the original failing CI as the compiled +binaries for the Windows and ARM platforms are only kept for seven days. If new commits are pushed to the pull request branch after the latest Jenkins CI run, a fresh CI run is required. It can be started by adding the `request-ci` From a01f45dbf2d7243d2956978219ac82756234be34 Mon Sep 17 00:00:00 2001 From: Stewart X Addison <6487691+sxa@users.noreply.github.com> Date: Fri, 16 Jan 2026 11:28:18 +0000 Subject: [PATCH 2/2] Update doc/contributing/collaborator-guide.md MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Tobias NieรŸen --- doc/contributing/collaborator-guide.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/contributing/collaborator-guide.md b/doc/contributing/collaborator-guide.md index 598daa950df8bf..6f2e400d440181 100644 --- a/doc/contributing/collaborator-guide.md +++ b/doc/contributing/collaborator-guide.md @@ -269,9 +269,9 @@ request, try the "๐Ÿ”„ Re-run all jobs" button, on the right-hand side of the If there are Jenkins CI failures unrelated to the change in the pull request, try "Resume Build". It is in the left navigation of the relevant -`node-test-pull-request` job (Do not be tempted to do this on the lower +`node-test-pull-request` job. (Do not be tempted to do this on the lower level `node-test-commit` job as it will not report the updated result back -to the PR). It will preserve all the green results from the current job but +to the PR.) It will preserve all the green results from the current job but re-run everything else. Start a fresh CI by pressing "Retry" if more than seven days have elapsed since the original failing CI as the compiled binaries for the Windows and ARM platforms are only kept for seven days.