fix(worker-ops): prevent scheduler stall on invalid request recovery

Author: liobrasil

cadence/contracts/FlowYieldVaultsEVMWorkerOps.cdc

@@ -491,10 +491,6 @@ access(all) contract FlowYieldVaultsEVMWorkerOps {
             let manager = FlowYieldVaultsEVMWorkerOps._getManagerFromStorage()!
             let worker = self.workerCap.borrow()!
 
-            // Always run failed-worker recovery before capacity checks.
-            // This prevents stale in-flight entries from blocking scheduler progress.
-            self._checkForFailedWorkerRequests(manager: manager, worker: worker)
-
             var message = ""
             var nextRunCapacity: UInt8 = 0
             var pendingCount: Int? = nil
@@ -508,7 +504,15 @@ access(all) contract FlowYieldVaultsEVMWorkerOps {
             // Calculate available capacity safely.
             // Guard against underflow if maxProcessingRequests is reduced while requests are in flight.
             let maxProcessingRequests = FlowYieldVaultsEVMWorkerOps.maxProcessingRequests
-            let currentInFlight = FlowYieldVaultsEVMWorkerOps.scheduledRequests.length
+            var currentInFlight = FlowYieldVaultsEVMWorkerOps.scheduledRequests.length
+
+            // If capacity is saturated, run failed-worker recovery first to clear stale entries
+            // that would otherwise block pending-request processing.
+            if currentInFlight >= Int(maxProcessingRequests) {
+                self._checkForFailedWorkerRequests(manager: manager, worker: worker)
+                currentInFlight = FlowYieldVaultsEVMWorkerOps.scheduledRequests.length
+            }
+
             // capacityLimit:
             // Remaining worker slots available right now, based on in-flight workers.
             // capacityLimit = max(0, maxProcessingRequests - currentInFlight)
@@ -574,10 +578,12 @@ access(all) contract FlowYieldVaultsEVMWorkerOps {
 
         /// @notice Main scheduler logic
         /// @dev Flow:
-        ///      1. If fetchCount > 0, fetch pending requests from EVM
-        ///      2. Preprocess requests to drop invalid requests
-        ///      3. Start processing requests (PENDING -> PROCESSING)
-        ///      4. Schedule WorkerHandlers and assign request ids to them
+        ///      1. Check for failed worker requests
+        ///         - If a failure is identified, mark the request as failed and remove it from scheduledRequests
+        ///      2. If fetchCount > 0, fetch pending requests from EVM
+        ///      3. Preprocess requests to drop invalid requests
+        ///      4. Start processing requests (PENDING -> PROCESSING)
+        ///      5. Schedule WorkerHandlers and assign request ids to them
         /// @param manager The scheduler manager
         /// @param worker The worker resource
         /// @param fetchCount Number of pending requests to fetch in this run
@@ -587,6 +593,9 @@ access(all) contract FlowYieldVaultsEVMWorkerOps {
             worker: &FlowYieldVaultsEVM.Worker,
             fetchCount: Int,
         ): String? {
+            // Check for failed worker requests
+            self._checkForFailedWorkerRequests(manager: manager, worker: worker)
+
             // Fetch pending requests from EVM
             if fetchCount > 0 {
                 if let pendingRequests = worker.getPendingRequestsFromEVM(