Fix: make OperatorPolicy history length configurable

Signed-off-by: yiraeChristineKim <[email protected]>

Author: yiraeChristineKim

controllers/operatorpolicy_controller.go

@@ -112,10 +112,13 @@ var (
 // OperatorPolicyReconciler reconciles a OperatorPolicy object
 type OperatorPolicyReconciler struct {
 	client.Client
-	DynamicClient     dynamic.Interface
-	DynamicWatcher    depclient.DynamicWatcher
-	InstanceName      string
-	DefaultNamespace  string
+	DynamicClient    dynamic.Interface
+	DynamicWatcher   depclient.DynamicWatcher
+	InstanceName     string
+	DefaultNamespace string
+	// MaxHistoryLength controls how many compliance history entries are stored in status.history.
+	// If set to < 1, it will default to 10.
+	MaxHistoryLength  int
 	TargetClient      client.Client
 	HubDynamicWatcher depclient.DynamicWatcher
 	HubClient         *kubernetes.Clientset
@@ -323,7 +326,11 @@ func (r *OperatorPolicyReconciler) Reconcile(ctx context.Context, req ctrl.Reque
 
 			policy.Status.History = append([]policyv1.HistoryEvent{newEvent}, policy.Status.History...)
 
-			maxHistoryLength := 10 // At some point, we may make this length configurable
+			maxHistoryLength := r.MaxHistoryLength
+			if maxHistoryLength < 1 {
+				maxHistoryLength = 10
+			}
+
 			if len(policy.Status.History) > maxHistoryLength {
 				policy.Status.History = policy.Status.History[:maxHistoryLength]
 			}

main.go

@@ -87,6 +87,7 @@ type ctrlOpts struct {
 	secureMetrics            bool
 	probeAddr                string
 	operatorPolDefaultNS     string
+	operatorPolHistoryLength uint16
 	clientQPS                float32
 	clientBurst              uint16
 	evalBackoffSeconds       uint32
@@ -583,6 +584,7 @@ func main() {
 			DynamicWatcher:    watcher,
 			InstanceName:      instanceName,
 			DefaultNamespace:  opts.operatorPolDefaultNS,
+			MaxHistoryLength:  int(opts.operatorPolHistoryLength),
 			TargetClient:      targetClient,
 			HubDynamicWatcher: opPolHubDynamicWatcher,
 			HubClient:         hubClient,
@@ -910,6 +912,13 @@ func parseOpts(flags *pflag.FlagSet, args []string) *ctrlOpts {
 		"The default namespace to be used by an OperatorPolicy if not specified in the policy.",
 	)
 
+	flags.Uint16Var(
+		&opts.operatorPolHistoryLength,
+		"operator-policy-status-history-length",
+		10,
+		"The maximum number of compliance history entries stored on the OperatorPolicy status.",
+	)
+
 	flags.BoolVar(
 		&opts.enableOcmPolicyNamespace,
 		"enable-ocm-policy-namespace",