Fix: Immediately return upon invalid message

Signed-off-by: yiraeChristineKim <[email protected]>

Author: yiraeChristineKim

controllers/operatorpolicy_status_test.go

@@ -37,6 +37,126 @@ func TestCalculateComplianceConditionShortCircuitOnInvalid(t *testing.T) {
 	assert.NotContains(t, cond.Message, "the status of the OperatorGroup could not be determined")
 	assert.NotContains(t, cond.Message, "the status of the Subscription could not be determined")
 	assert.NotContains(t, cond.Message, "the status of the InstallPlan could not be determined")
+	assert.NotContains(t, cond.Message, "the OperatorGroup is compliant")
+}
+
+func TestShortCircuitOnMissingValidPolicySpec(t *testing.T) {
+	pol := &policyv1beta1.OperatorPolicy{}
+
+	cond := calculateComplianceCondition(pol)
+
+	assert.Equal(t, metav1.ConditionFalse, cond.Status)
+	assert.Equal(t, "NonCompliant; the validity of the policy is unknown", cond.Message)
+}
+
+func TestShortCircuitOnMissingOperatorGroup(t *testing.T) {
+	pol := &policyv1beta1.OperatorPolicy{}
+	pol.Status.Conditions = []metav1.Condition{
+		{
+			Type:    validPolicyConditionType,
+			Status:  metav1.ConditionTrue,
+			Reason:  "PolicyValidated",
+			Message: "the policy spec is valid",
+		},
+	}
+
+	cond := calculateComplianceCondition(pol)
+
+	assert.Equal(t, metav1.ConditionFalse, cond.Status)
+	assert.Equal(t, "NonCompliant; the status of the OperatorGroup is unknown", cond.Message)
+}
+
+func TestShortCircuitOnMissingSubscription(t *testing.T) {
+	pol := &policyv1beta1.OperatorPolicy{}
+	pol.Status.Conditions = []metav1.Condition{
+		{
+			Type:    validPolicyConditionType,
+			Status:  metav1.ConditionTrue,
+			Reason:  "PolicyValidated",
+			Message: "the policy spec is valid",
+		},
+		{
+			Type:    opGroupConditionType,
+			Status:  metav1.ConditionTrue,
+			Reason:  "OperatorGroupCompliant",
+			Message: "the OperatorGroup is compliant",
+		},
+	}
+
+	cond := calculateComplianceCondition(pol)
+
+	assert.Equal(t, metav1.ConditionFalse, cond.Status)
+	assert.Equal(t, "NonCompliant; the status of the Subscription is unknown", cond.Message)
+}
+
+func TestCalculateComplianceConditionAggregatesAllCompliant(t *testing.T) {
+	pol := &policyv1beta1.OperatorPolicy{}
+	pol.Status.Conditions = []metav1.Condition{
+		{
+			Type:    validPolicyConditionType,
+			Status:  metav1.ConditionTrue,
+			Reason:  "PolicyValidated",
+			Message: "the policy spec is valid",
+		},
+		{
+			Type:    opGroupConditionType,
+			Status:  metav1.ConditionTrue,
+			Reason:  "OperatorGroupMatches",
+			Message: "the OperatorGroup matches what is required by the policy",
+		},
+		{
+			Type:    subConditionType,
+			Status:  metav1.ConditionTrue,
+			Reason:  "SubscriptionMatches",
+			Message: "the Subscription matches what is required by the policy",
+		},
+		{
+			Type:    installPlanConditionType,
+			Status:  metav1.ConditionTrue,
+			Reason:  "NoInstallPlansFound",
+			Message: "there are no relevant InstallPlans in the namespace",
+		},
+		{
+			Type:    csvConditionType,
+			Status:  metav1.ConditionTrue,
+			Reason:  "Succeeded",
+			Message: "the ClusterServiceVersion is succeeded",
+		},
+		{
+			Type:    crdConditionType,
+			Status:  metav1.ConditionTrue,
+			Reason:  "RelevantCRDFound",
+			Message: "there are CRDs present for the operator",
+		},
+		{
+			Type:    deploymentConditionType,
+			Status:  metav1.ConditionTrue,
+			Reason:  "DeploymentsAvailable",
+			Message: "all operator Deployments have their minimum availability",
+		},
+		// CatalogSource polarity: False means healthy/non-blocking for compliance aggregation
+		{
+			Type:    catalogSrcConditionType,
+			Status:  metav1.ConditionFalse,
+			Reason:  "CatalogSourcesFound",
+			Message: "CatalogSource was found",
+		},
+	}
+
+	cond := calculateComplianceCondition(pol)
+
+	expected := "Compliant; " +
+		"the policy spec is valid, " +
+		"the OperatorGroup matches what is required by the policy, " +
+		"the Subscription matches what is required by the policy, " +
+		"there are no relevant InstallPlans in the namespace, " +
+		"the ClusterServiceVersion is succeeded, " +
+		"there are CRDs present for the operator, " +
+		"all operator Deployments have their minimum availability, " +
+		"CatalogSource was found"
+
+	assert.Equal(t, metav1.ConditionTrue, cond.Status)
+	assert.Equal(t, expected, cond.Message)
 }
 
 func TestExistingInstallPlanObj(t *testing.T) {