chore: update sdk readmes#1394
Conversation
Signed-off-by: OpenFeature Bot <109696520+openfeaturebot@users.noreply.github.com>
✅ Deploy Preview for openfeature ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the PHP SDK documentation to version 2.2.0, introducing comprehensive documentation for the new MultiProvider feature, its evaluation strategies, error handling, and custom strategy implementation. It also updates the SDK compatibility dataset and auto-generated timestamps across multiple SDK documentation files. The review feedback suggests correcting the spelling of 'behaviour' to 'behavior' in two instances within the PHP documentation to maintain consistency.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
|
||
| By default, the Multi-Provider will evaluate all underlying providers in order and return the **first successful result**. If a provider indicates it does not have a flag (`FLAG_NOT_FOUND` error code), then it will be skipped and the next provider will be evaluated. If any provider throws or returns an error result, the operation will fail and the error will be returned. If no provider returns a successful result, the operation will fail with a `FLAG_NOT_FOUND` error code. | ||
|
|
||
| To change this behaviour, a different "strategy" can be provided: |
There was a problem hiding this comment.
To maintain spelling consistency with the rest of the document (which uses "behavior"), please use the American spelling "behavior" here.
To change this behavior, a different "strategy" can be provided:
|
|
||
| 1. **FirstMatchStrategy** (default): Evaluates all providers in order and returns the first successful result. Providers that indicate `FLAG_NOT_FOUND` error will be skipped and the next provider will be evaluated. Any other error will cause the operation to fail and the error to be returned. | ||
| 2. **FirstSuccessfulStrategy**: Evaluates all providers in order and returns the first successful result. Any error will cause that provider to be skipped. If no successful result is returned, the set of errors will be returned. | ||
| 3. **ComparisonStrategy**: Evaluates all providers at one time. If every provider returns a successful result with the same value, then that result is returned. Otherwise, an error is returned immediately if any provider errors. When values do not agree, an optional callback will be executed to notify you of the mismatch, and the configured "fallback provider" value will be used. This can be useful when migrating between providers that are expected to contain identical configuration. You can easily spot mismatches in configuration without affecting flag behaviour. |
There was a problem hiding this comment.
To maintain spelling consistency with the rest of the document (which uses "behavior"), please use the American spelling "behavior" here.
3. **ComparisonStrategy**: Evaluates all providers at one time. If every provider returns a successful result with the same value, then that result is returned. Otherwise, an error is returned immediately if any provider errors. When values do not agree, an optional callback will be executed to notify you of the mismatch, and the configured "fallback provider" value will be used. This can be useful when migrating between providers that are expected to contain identical configuration. You can easily spot mismatches in configuration without affecting flag behavior.
1 participant
The PR was automatically generated via the update-sdk-docs GitHub workflow.