Skip to content

Commit 2e2b584

Browse files
committed
Fix importing of JITAR sets.
The settings `att_to_open_children` and `counts_parent_grade` were not being transferred from the set definition file due to incorrect casing used. Thanks to @hal4stvf for pointing this out. Part of the problem here is the mix of snake case and cammel case. The set definition file, the problem table in the database, and the default value from `defaults.config` use `att_to_open_children`. However, the `addProblemToSet` method expects the argument of `attToOpenChildren`. We need to eliminate snake case usage altogether. It is the most annoying case to type (`shift _ t` takes three keystrokes but `shift t` only takes two). But even worse is mixing these different casing schemes, particularly as is done in this case. This fixes issue #2897.
1 parent 5cf8bf9 commit 2e2b584

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

lib/WeBWorK/File/SetDef.pm

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -197,8 +197,8 @@ sub importSetsFromDef ($ce, $db, $setDefFiles, $existingSets = undef, $assign =
197197
showMeAnother => $rh_problem->{showMeAnother},
198198
showHintsAfter => $rh_problem->{showHintsAfter},
199199
prPeriod => $rh_problem->{prPeriod},
200-
attToOpenChildren => $rh_problem->{attToOpenChildren},
201-
countsParentGrade => $rh_problem->{countsParentGrade}
200+
attToOpenChildren => $rh_problem->{att_to_open_children},
201+
countsParentGrade => $rh_problem->{counts_parent_grade}
202202
);
203203
}
204204

0 commit comments

Comments
 (0)